From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 2E2034BE1; Thu,  6 Jul 2017 15:16:38 +0200 (CEST)
In-Reply-To: <1499377952-5306-1-git-send-email-nikhil.rao@intel.com>
References: <1499377952-5306-1-git-send-email-nikhil.rao@intel.com>
To: test-report@dpdk.org
Cc: Nikhil Rao <nikhil.rao@intel.com>
Message-Id: <20170706131638.2E2034BE1@dpdk.org>
Date: Thu,  6 Jul 2017 15:16:38 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw26534 [PATCH 1/2] eventdev: add
	event adapter for ethernet Rx queues
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Jul 2017 13:16:38 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/26534

_coding style issues_


WARNING:LONG_LINE: line over 90 characters
#339: FILE: lib/librte_eventdev/rte_event_eth_rx_adapter.h:253:
+				       const struct rte_event_eth_rx_adapter_queue_conf *conf);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#916: FILE: lib/librte_eventdev/rte_event_eth_rx_adapter.c:523:
+	unsigned sz;

WARNING:LONG_LINE: line over 90 characters
#940: FILE: lib/librte_eventdev/rte_event_eth_rx_adapter.c:547:
+	rss_key_be = (void *)&rte_event_eth_rx_adapter[RTE_MAX_EVENT_ETH_RX_ADAPTER_INSTANCE];

WARNING:BRACES: braces {} are not necessary for single statement blocks
#960: FILE: lib/librte_eventdev/rte_event_eth_rx_adapter.c:567:
+	if (rte_event_eth_rx_adapter[id]) {
+		return -EEXIST;
+	}

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 24)
#1041: FILE: lib/librte_eventdev/rte_event_eth_rx_adapter.c:648:
+	for (i = 0; i < rte_eth_dev_count(); i++)
+			rte_free(rx_adapter->eth_devices[i].rx_queue);

WARNING:LONG_LINE: line over 90 characters
#1075: FILE: lib/librte_eventdev/rte_event_eth_rx_adapter.c:682:
+				    const struct rte_event_eth_rx_adapter_queue_conf *conf)

WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'conf->rx_queue_flags'
#1103: FILE: lib/librte_eventdev/rte_event_eth_rx_adapter.c:710:
+	if (conf->
+	    rx_queue_flags & RTE_EVENT_ETH_RX_ADAPTER_QUEUE_FLOW_ID_VALID) {

total: 0 errors, 7 warnings, 1164 lines checked