From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 1017) id 5E14D5689; Thu, 6 Jul 2017 15:45:06 +0200 (CEST) In-Reply-To: <1499348668-2155-2-git-send-email-olivier.chirossel@gmail.com> References: <1499348668-2155-2-git-send-email-olivier.chirossel@gmail.com> To: test-report@dpdk.org Cc: Olivier Chirossel Message-Id: <20170706134506.5E14D5689@dpdk.org> Date: Thu, 6 Jul 2017 15:45:06 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw26539 [PATCH v3] lib/librte_sched: fix update tc_credits X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Jul 2017 13:45:06 -0000 Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/26539 _coding style issues_ ERROR:TRAILING_WHITESPACE: trailing whitespace #56: FILE: lib/librte_sched/rte_sched.c:88: +^Iuint32_t tc_rate[RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE]; $ ERROR:TRAILING_WHITESPACE: trailing whitespace #74: FILE: lib/librte_sched/rte_sched.c:573: +^I$ ERROR:CODE_INDENT: code indent should use tabs where possible #76: FILE: lib/librte_sched/rte_sched.c:575: +^I^I dst->tc_rate[j] = src->tc_rate[j];$ ERROR:TRAILING_WHITESPACE: trailing whitespace #81: FILE: lib/librte_sched/rte_sched.c:580: +^I$ ERROR:CODE_INDENT: code indent should use tabs where possible #89: FILE: lib/librte_sched/rte_sched.c:846: +^I s->tc_rate[i] = params->tc_rate[i];$ WARNING:LONG_LINE: line over 90 characters #101: FILE: lib/librte_sched/rte_sched.c:1504: + if (likely((subport->tc_credits[0] + subport->tc_credits_per_period[0]) < subport->tc_rate[0])) { ERROR:CODE_INDENT: code indent should use tabs where possible #101: FILE: lib/librte_sched/rte_sched.c:1504: +^I if (likely((subport->tc_credits[0] + subport->tc_credits_per_period[0]) < subport->tc_rate[0])) {$ WARNING:BRACES: braces {} are not necessary for any arm of this statement #101: FILE: lib/librte_sched/rte_sched.c:1504: + if (likely((subport->tc_credits[0] + subport->tc_credits_per_period[0]) < subport->tc_rate[0])) { [...] + else { [...] ERROR:CODE_INDENT: code indent should use tabs where possible #102: FILE: lib/librte_sched/rte_sched.c:1505: +^I^I subport->tc_credits[0] += subport->tc_credits_per_period[0];$ ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' #104: FILE: lib/librte_sched/rte_sched.c:1507: + } + else { ERROR:CODE_INDENT: code indent should use tabs where possible #105: FILE: lib/librte_sched/rte_sched.c:1508: +^I^I subport->tc_credits[0] = subport->tc_rate[0];$ WARNING:LONG_LINE: line over 90 characters #107: FILE: lib/librte_sched/rte_sched.c:1510: + if (likely((subport->tc_credits[1] + subport->tc_credits_per_period[1]) < subport->tc_rate[1])) { WARNING:BRACES: braces {} are not necessary for any arm of this statement #107: FILE: lib/librte_sched/rte_sched.c:1510: + if (likely((subport->tc_credits[1] + subport->tc_credits_per_period[1]) < subport->tc_rate[1])) { [...] + else { [...] ERROR:CODE_INDENT: code indent should use tabs where possible #108: FILE: lib/librte_sched/rte_sched.c:1511: +^I^I subport->tc_credits[1] += subport->tc_credits_per_period[1];$ ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' #110: FILE: lib/librte_sched/rte_sched.c:1513: + } + else { ERROR:CODE_INDENT: code indent should use tabs where possible #111: FILE: lib/librte_sched/rte_sched.c:1514: +^I^I subport->tc_credits[1] = subport->tc_rate[1];$ WARNING:LONG_LINE: line over 90 characters #113: FILE: lib/librte_sched/rte_sched.c:1516: + if (likely((subport->tc_credits[2] + subport->tc_credits_per_period[2]) < subport->tc_rate[2])) { WARNING:BRACES: braces {} are not necessary for any arm of this statement #113: FILE: lib/librte_sched/rte_sched.c:1516: + if (likely((subport->tc_credits[2] + subport->tc_credits_per_period[2]) < subport->tc_rate[2])) { [...] + else { [...] ERROR:CODE_INDENT: code indent should use tabs where possible #114: FILE: lib/librte_sched/rte_sched.c:1517: +^I^I subport->tc_credits[2] += subport->tc_credits_per_period[2];$ ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' #116: FILE: lib/librte_sched/rte_sched.c:1519: + } + else { ERROR:CODE_INDENT: code indent should use tabs where possible #117: FILE: lib/librte_sched/rte_sched.c:1520: +^I^I subport->tc_credits[2] = subport->tc_rate[2];$ WARNING:LONG_LINE: line over 90 characters #119: FILE: lib/librte_sched/rte_sched.c:1522: + if (likely((subport->tc_credits[3] + subport->tc_credits_per_period[3]) < subport->tc_rate[3])) { WARNING:BRACES: braces {} are not necessary for any arm of this statement #119: FILE: lib/librte_sched/rte_sched.c:1522: + if (likely((subport->tc_credits[3] + subport->tc_credits_per_period[3]) < subport->tc_rate[3])) { [...] + else { [...] ERROR:CODE_INDENT: code indent should use tabs where possible #120: FILE: lib/librte_sched/rte_sched.c:1523: +^I^I subport->tc_credits[3] += subport->tc_credits_per_period[3];$ ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' #122: FILE: lib/librte_sched/rte_sched.c:1525: + } + else { ERROR:CODE_INDENT: code indent should use tabs where possible #123: FILE: lib/librte_sched/rte_sched.c:1526: +^I^I subport->tc_credits[3] = subport->tc_rate[3];$ WARNING:LONG_LINE: line over 90 characters #134: FILE: lib/librte_sched/rte_sched.c:1533: + if (likely((pipe->tc_credits[0] + params->tc_credits_per_period[0]) < params->tc_rate[0])) { ERROR:CODE_INDENT: code indent should use tabs where possible #134: FILE: lib/librte_sched/rte_sched.c:1533: +^I if (likely((pipe->tc_credits[0] + params->tc_credits_per_period[0]) < params->tc_rate[0])) {$ WARNING:BRACES: braces {} are not necessary for any arm of this statement #134: FILE: lib/librte_sched/rte_sched.c:1533: + if (likely((pipe->tc_credits[0] + params->tc_credits_per_period[0]) < params->tc_rate[0])) { [...] + else { [...] ERROR:CODE_INDENT: code indent should use tabs where possible #135: FILE: lib/librte_sched/rte_sched.c:1534: +^I^I pipe->tc_credits[0] += params->tc_credits_per_period[0];$ ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' #137: FILE: lib/librte_sched/rte_sched.c:1536: + } + else { ERROR:CODE_INDENT: code indent should use tabs where possible #138: FILE: lib/librte_sched/rte_sched.c:1537: +^I^I pipe->tc_credits[0] = params->tc_rate[0];$ WARNING:LONG_LINE: line over 90 characters #140: FILE: lib/librte_sched/rte_sched.c:1539: + if (likely((pipe->tc_credits[1] + params->tc_credits_per_period[1]) < params->tc_rate[1])) { ERROR:CODE_INDENT: code indent should use tabs where possible #140: FILE: lib/librte_sched/rte_sched.c:1539: +^I if (likely((pipe->tc_credits[1] + params->tc_credits_per_period[1]) < params->tc_rate[1])) {$ WARNING:BRACES: braces {} are not necessary for any arm of this statement #140: FILE: lib/librte_sched/rte_sched.c:1539: + if (likely((pipe->tc_credits[1] + params->tc_credits_per_period[1]) < params->tc_rate[1])) { [...] + else { [...] ERROR:CODE_INDENT: code indent should use tabs where possible #141: FILE: lib/librte_sched/rte_sched.c:1540: +^I^I pipe->tc_credits[1] += params->tc_credits_per_period[1];$ ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' #143: FILE: lib/librte_sched/rte_sched.c:1542: + } + else { ERROR:CODE_INDENT: code indent should use tabs where possible #144: FILE: lib/librte_sched/rte_sched.c:1543: +^I^I pipe->tc_credits[1] = params->tc_rate[1];$ WARNING:LONG_LINE: line over 90 characters #146: FILE: lib/librte_sched/rte_sched.c:1545: + if (likely((pipe->tc_credits[2] + params->tc_credits_per_period[2]) < params->tc_rate[2])) { ERROR:CODE_INDENT: code indent should use tabs where possible #146: FILE: lib/librte_sched/rte_sched.c:1545: +^I if (likely((pipe->tc_credits[2] + params->tc_credits_per_period[2]) < params->tc_rate[2])) {$ WARNING:BRACES: braces {} are not necessary for any arm of this statement #146: FILE: lib/librte_sched/rte_sched.c:1545: + if (likely((pipe->tc_credits[2] + params->tc_credits_per_period[2]) < params->tc_rate[2])) { [...] + else { [...] ERROR:CODE_INDENT: code indent should use tabs where possible #147: FILE: lib/librte_sched/rte_sched.c:1546: +^I^I pipe->tc_credits[2] += params->tc_credits_per_period[2];$ ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' #149: FILE: lib/librte_sched/rte_sched.c:1548: + } + else { ERROR:CODE_INDENT: code indent should use tabs where possible #150: FILE: lib/librte_sched/rte_sched.c:1549: +^I^I pipe->tc_credits[2] = params->tc_rate[2];$ WARNING:LONG_LINE: line over 90 characters #152: FILE: lib/librte_sched/rte_sched.c:1551: + if (likely((pipe->tc_credits[3] + params->tc_credits_per_period[3]) < params->tc_rate[3])) { ERROR:CODE_INDENT: code indent should use tabs where possible #152: FILE: lib/librte_sched/rte_sched.c:1551: +^I if (likely((pipe->tc_credits[3] + params->tc_credits_per_period[3]) < params->tc_rate[3])) {$ WARNING:BRACES: braces {} are not necessary for any arm of this statement #152: FILE: lib/librte_sched/rte_sched.c:1551: + if (likely((pipe->tc_credits[3] + params->tc_credits_per_period[3]) < params->tc_rate[3])) { [...] + else { [...] ERROR:CODE_INDENT: code indent should use tabs where possible #153: FILE: lib/librte_sched/rte_sched.c:1552: +^I^I pipe->tc_credits[3] += params->tc_credits_per_period[3];$ ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' #155: FILE: lib/librte_sched/rte_sched.c:1554: + } + else { ERROR:CODE_INDENT: code indent should use tabs where possible #156: FILE: lib/librte_sched/rte_sched.c:1555: +^I^I pipe->tc_credits[3] = params->tc_rate[3];$ WARNING:LONG_LINE: line over 90 characters #171: FILE: lib/librte_sched/rte_sched.c:1622: + if (likely((subport->tc_credits[0] + subport->tc_credits_per_period[0]) < subport->tc_rate[0])) { WARNING:BRACES: braces {} are not necessary for any arm of this statement #171: FILE: lib/librte_sched/rte_sched.c:1622: + if (likely((subport->tc_credits[0] + subport->tc_credits_per_period[0]) < subport->tc_rate[0])) { [...] + else { [...] ERROR:CODE_INDENT: code indent should use tabs where possible #172: FILE: lib/librte_sched/rte_sched.c:1623: +^I^I subport->tc_credits[0] += subport->tc_credits_per_period[0];$ ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' #174: FILE: lib/librte_sched/rte_sched.c:1625: + } + else { ERROR:CODE_INDENT: code indent should use tabs where possible #175: FILE: lib/librte_sched/rte_sched.c:1626: +^I^I subport->tc_credits[0] = subport->tc_rate[0];$ WARNING:LONG_LINE: line over 90 characters #177: FILE: lib/librte_sched/rte_sched.c:1628: + if (likely((subport->tc_credits[1] + subport->tc_credits_per_period[1]) < subport->tc_rate[1])) { WARNING:BRACES: braces {} are not necessary for any arm of this statement #177: FILE: lib/librte_sched/rte_sched.c:1628: + if (likely((subport->tc_credits[1] + subport->tc_credits_per_period[1]) < subport->tc_rate[1])) { [...] + else { [...] ERROR:CODE_INDENT: code indent should use tabs where possible #178: FILE: lib/librte_sched/rte_sched.c:1629: +^I^I subport->tc_credits[1] += subport->tc_credits_per_period[1];$ ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' #180: FILE: lib/librte_sched/rte_sched.c:1631: + } + else { ERROR:CODE_INDENT: code indent should use tabs where possible #181: FILE: lib/librte_sched/rte_sched.c:1632: +^I^I subport->tc_credits[1] = subport->tc_rate[1];$ WARNING:LONG_LINE: line over 90 characters #183: FILE: lib/librte_sched/rte_sched.c:1634: + if (likely((subport->tc_credits[2] + subport->tc_credits_per_period[2]) < subport->tc_rate[2])) { WARNING:BRACES: braces {} are not necessary for any arm of this statement #183: FILE: lib/librte_sched/rte_sched.c:1634: + if (likely((subport->tc_credits[2] + subport->tc_credits_per_period[2]) < subport->tc_rate[2])) { [...] + else { [...] ERROR:CODE_INDENT: code indent should use tabs where possible #184: FILE: lib/librte_sched/rte_sched.c:1635: +^I^I subport->tc_credits[2] += subport->tc_credits_per_period[2];$ ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' #186: FILE: lib/librte_sched/rte_sched.c:1637: + } + else { WARNING:LONG_LINE: line over 90 characters #189: FILE: lib/librte_sched/rte_sched.c:1640: + if (likely((subport->tc_credits[3] + subport->tc_credits_per_period[3]) < subport->tc_rate[3])) { WARNING:BRACES: braces {} are not necessary for any arm of this statement #189: FILE: lib/librte_sched/rte_sched.c:1640: + if (likely((subport->tc_credits[3] + subport->tc_credits_per_period[3]) < subport->tc_rate[3])) { [...] + else { [...] ERROR:CODE_INDENT: code indent should use tabs where possible #190: FILE: lib/librte_sched/rte_sched.c:1641: +^I^I subport->tc_credits[3] += subport->tc_credits_per_period[3];$ ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' #192: FILE: lib/librte_sched/rte_sched.c:1643: + } + else { ERROR:CODE_INDENT: code indent should use tabs where possible #193: FILE: lib/librte_sched/rte_sched.c:1644: +^I^I subport->tc_credits[3] = subport->tc_rate[3];$ WARNING:LONG_LINE: line over 90 characters #205: FILE: lib/librte_sched/rte_sched.c:1652: + if (likely((pipe->tc_credits[0] + params->tc_credits_per_period[0]) < params->tc_rate[0])) { ERROR:CODE_INDENT: code indent should use tabs where possible #205: FILE: lib/librte_sched/rte_sched.c:1652: +^I if (likely((pipe->tc_credits[0] + params->tc_credits_per_period[0]) < params->tc_rate[0])) {$ WARNING:BRACES: braces {} are not necessary for any arm of this statement #205: FILE: lib/librte_sched/rte_sched.c:1652: + if (likely((pipe->tc_credits[0] + params->tc_credits_per_period[0]) < params->tc_rate[0])) { [...] + else { [...] ERROR:CODE_INDENT: code indent should use tabs where possible #206: FILE: lib/librte_sched/rte_sched.c:1653: +^I^I pipe->tc_credits[0] += params->tc_credits_per_period[0];$ ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' #208: FILE: lib/librte_sched/rte_sched.c:1655: + } + else { ERROR:CODE_INDENT: code indent should use tabs where possible #209: FILE: lib/librte_sched/rte_sched.c:1656: +^I^I pipe->tc_credits[0] = params->tc_rate[0];$ WARNING:LONG_LINE: line over 90 characters #211: FILE: lib/librte_sched/rte_sched.c:1658: + if (likely((pipe->tc_credits[1] + params->tc_credits_per_period[1]) < params->tc_rate[1])) { ERROR:CODE_INDENT: code indent should use tabs where possible #211: FILE: lib/librte_sched/rte_sched.c:1658: +^I if (likely((pipe->tc_credits[1] + params->tc_credits_per_period[1]) < params->tc_rate[1])) {$ WARNING:BRACES: braces {} are not necessary for any arm of this statement #211: FILE: lib/librte_sched/rte_sched.c:1658: + if (likely((pipe->tc_credits[1] + params->tc_credits_per_period[1]) < params->tc_rate[1])) { [...] + else { [...] ERROR:CODE_INDENT: code indent should use tabs where possible #212: FILE: lib/librte_sched/rte_sched.c:1659: +^I^I pipe->tc_credits[1] += params->tc_credits_per_period[1];$ ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' #214: FILE: lib/librte_sched/rte_sched.c:1661: + } + else { ERROR:CODE_INDENT: code indent should use tabs where possible #215: FILE: lib/librte_sched/rte_sched.c:1662: +^I^I pipe->tc_credits[1] = params->tc_rate[1];$ WARNING:LONG_LINE: line over 90 characters #217: FILE: lib/librte_sched/rte_sched.c:1664: + if (likely((pipe->tc_credits[2] + params->tc_credits_per_period[2]) < params->tc_rate[2])) { ERROR:CODE_INDENT: code indent should use tabs where possible #217: FILE: lib/librte_sched/rte_sched.c:1664: +^I if (likely((pipe->tc_credits[2] + params->tc_credits_per_period[2]) < params->tc_rate[2])) {$ WARNING:BRACES: braces {} are not necessary for any arm of this statement #217: FILE: lib/librte_sched/rte_sched.c:1664: + if (likely((pipe->tc_credits[2] + params->tc_credits_per_period[2]) < params->tc_rate[2])) { [...] + else { [...] ERROR:CODE_INDENT: code indent should use tabs where possible #218: FILE: lib/librte_sched/rte_sched.c:1665: +^I^I pipe->tc_credits[2] += params->tc_credits_per_period[2];$ ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' #220: FILE: lib/librte_sched/rte_sched.c:1667: + } + else { ERROR:CODE_INDENT: code indent should use tabs where possible #221: FILE: lib/librte_sched/rte_sched.c:1668: +^I^I pipe->tc_credits[2] = params->tc_rate[2];$ WARNING:LONG_LINE: line over 90 characters #223: FILE: lib/librte_sched/rte_sched.c:1670: + if (likely((pipe->tc_credits[3] + params->tc_credits_per_period[3]) < params->tc_rate[3])) { ERROR:CODE_INDENT: code indent should use tabs where possible #223: FILE: lib/librte_sched/rte_sched.c:1670: +^I if (likely((pipe->tc_credits[3] + params->tc_credits_per_period[3]) < params->tc_rate[3])) {$ WARNING:BRACES: braces {} are not necessary for any arm of this statement #223: FILE: lib/librte_sched/rte_sched.c:1670: + if (likely((pipe->tc_credits[3] + params->tc_credits_per_period[3]) < params->tc_rate[3])) { [...] + else { [...] ERROR:CODE_INDENT: code indent should use tabs where possible #224: FILE: lib/librte_sched/rte_sched.c:1671: +^I^I pipe->tc_credits[3] += params->tc_credits_per_period[3];$ ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' #226: FILE: lib/librte_sched/rte_sched.c:1673: + } + else { ERROR:CODE_INDENT: code indent should use tabs where possible #227: FILE: lib/librte_sched/rte_sched.c:1674: +^I^I pipe->tc_credits[3] = params->tc_rate[3];$ ERROR:CODE_INDENT: code indent should use tabs where possible #228: FILE: lib/librte_sched/rte_sched.c:1675: +^I }$ total: 62 errors, 32 warnings, 196 lines checked