From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 340F73256; Thu,  6 Jul 2017 20:42:49 +0200 (CEST)
In-Reply-To: <cb0f918cdf578622b7e7fc44af2342d3232c1859.1499366233.git.yskoh@mellanox.com>
References: <cb0f918cdf578622b7e7fc44af2342d3232c1859.1499366233.git.yskoh@mellanox.com>
To: test-report@dpdk.org
Cc: Yongseok Koh <yskoh@mellanox.com>
Message-Id: <20170706184249.340F73256@dpdk.org>
Date: Thu,  6 Jul 2017 20:42:49 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw26560 [PATCH v4 5/5] net/mlx5: add
	vectorized Rx/Tx burst for x86
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Jul 2017 18:42:49 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/26560

_coding style issues_


WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#156: FILE: drivers/net/mlx5/mlx5_rxq.c:663:
+			return ENOMEM;

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name
#781: FILE: drivers/net/mlx5/mlx5_rxtx.h:350:
+int priv_check_raw_vec_tx_support(struct priv *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name
#782: FILE: drivers/net/mlx5/mlx5_rxtx.h:351:
+int priv_check_vec_tx_support(struct priv *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct rxq *' should also have an identifier name
#783: FILE: drivers/net/mlx5/mlx5_rxtx.h:352:
+int rxq_check_vec_support(struct rxq *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name
#784: FILE: drivers/net/mlx5/mlx5_rxtx.h:353:
+int priv_check_vec_rx_support(struct priv *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name
#785: FILE: drivers/net/mlx5/mlx5_rxtx.h:354:
+void priv_prep_vec_rx_function(struct priv *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'void *' should also have an identifier name
#786: FILE: drivers/net/mlx5/mlx5_rxtx.h:355:
+uint16_t mlx5_tx_burst_raw_vec(void *, struct rte_mbuf **, uint16_t);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct rte_mbuf **' should also have an identifier name
#786: FILE: drivers/net/mlx5/mlx5_rxtx.h:355:
+uint16_t mlx5_tx_burst_raw_vec(void *, struct rte_mbuf **, uint16_t);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint16_t' should also have an identifier name
#786: FILE: drivers/net/mlx5/mlx5_rxtx.h:355:
+uint16_t mlx5_tx_burst_raw_vec(void *, struct rte_mbuf **, uint16_t);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'void *' should also have an identifier name
#787: FILE: drivers/net/mlx5/mlx5_rxtx.h:356:
+uint16_t mlx5_tx_burst_vec(void *, struct rte_mbuf **, uint16_t);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct rte_mbuf **' should also have an identifier name
#787: FILE: drivers/net/mlx5/mlx5_rxtx.h:356:
+uint16_t mlx5_tx_burst_vec(void *, struct rte_mbuf **, uint16_t);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint16_t' should also have an identifier name
#787: FILE: drivers/net/mlx5/mlx5_rxtx.h:356:
+uint16_t mlx5_tx_burst_vec(void *, struct rte_mbuf **, uint16_t);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'void *' should also have an identifier name
#788: FILE: drivers/net/mlx5/mlx5_rxtx.h:357:
+uint16_t mlx5_rx_burst_vec(void *, struct rte_mbuf **, uint16_t);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct rte_mbuf **' should also have an identifier name
#788: FILE: drivers/net/mlx5/mlx5_rxtx.h:357:
+uint16_t mlx5_rx_burst_vec(void *, struct rte_mbuf **, uint16_t);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint16_t' should also have an identifier name
#788: FILE: drivers/net/mlx5/mlx5_rxtx.h:357:
+uint16_t mlx5_rx_burst_vec(void *, struct rte_mbuf **, uint16_t);

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#1151: FILE: drivers/net/mlx5/mlx5_rxtx_vec_sse.c:87:
+txq_wr_dseg_v(struct txq *txq, __m128i *dseg,
                                        ^

total: 0 errors, 15 warnings, 1 checks, 2370 lines checked