automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Gaetan Rivet <gaetan.rivet@6wind.com>
Subject: [dpdk-test-report] |WARNING| pw26746 [PATCH v8 03/11] net/failsafe: add fail-safe PMD
Date: Tue, 11 Jul 2017 01:20:53 +0200 (CEST)	[thread overview]
Message-ID: <20170710232053.072A97D0F@dpdk.org> (raw)
In-Reply-To: <f1e9f9e386c72caecb1019daca5e0f35f3bf0265.1499728587.git.gaetan.rivet@6wind.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/26746

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <PRIu8>
#1718: FILE: drivers/net/failsafe/failsafe_ops.c:614:
+			      PRIu8 " with error %d", i, ret);

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i' - possible side-effects?
#1928: FILE: drivers/net/failsafe/failsafe_private.h:155:
+#define FOREACH_SUBDEV_ST(s, i, dev, state)				\
+	for (i = fs_find_next((dev), 0, state);				\
+	     i < PRIV(dev)->subs_tail && (s = &PRIV(dev)->subs[i]);	\
+	     i = fs_find_next((dev), i + 1, state))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev' - possible side-effects?
#1928: FILE: drivers/net/failsafe/failsafe_private.h:155:
+#define FOREACH_SUBDEV_ST(s, i, dev, state)				\
+	for (i = fs_find_next((dev), 0, state);				\
+	     i < PRIV(dev)->subs_tail && (s = &PRIV(dev)->subs[i]);	\
+	     i = fs_find_next((dev), i + 1, state))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'state' - possible side-effects?
#1928: FILE: drivers/net/failsafe/failsafe_private.h:155:
+#define FOREACH_SUBDEV_ST(s, i, dev, state)				\
+	for (i = fs_find_next((dev), 0, state);				\
+	     i < PRIV(dev)->subs_tail && (s = &PRIV(dev)->subs[i]);	\
+	     i = fs_find_next((dev), i + 1, state))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev' - possible side-effects?
#1947: FILE: drivers/net/failsafe/failsafe_private.h:174:
+#define TX_SUBDEV(dev)							  \
+	(PRIV(dev)->subs_tx >= PRIV(dev)->subs_tail		   ? NULL \
+	 : (PRIV(dev)->subs[PRIV(dev)->subs_tx].state < DEV_PROBED ? NULL \
+	 : &PRIV(dev)->subs[PRIV(dev)->subs_tx]))

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'ops' may be better as '(ops)' to avoid precedence issues
#1956: FILE: drivers/net/failsafe/failsafe_private.h:183:
+#define SUBOPS(s, ops) \
+	(ETH(s)->dev_ops->ops)

total: 0 errors, 0 warnings, 1992 lines checked

           reply	other threads:[~2017-07-10 23:20 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <f1e9f9e386c72caecb1019daca5e0f35f3bf0265.1499728587.git.gaetan.rivet@6wind.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170710232053.072A97D0F@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=gaetan.rivet@6wind.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).