From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 1017) id 072A97D0F; Tue, 11 Jul 2017 01:20:53 +0200 (CEST) In-Reply-To: References: To: test-report@dpdk.org Cc: Gaetan Rivet Message-Id: <20170710232053.072A97D0F@dpdk.org> Date: Tue, 11 Jul 2017 01:20:53 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw26746 [PATCH v8 03/11] net/failsafe: add fail-safe PMD X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Jul 2017 23:20:53 -0000 Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/26746 _coding style issues_ CHECK:CAMELCASE: Avoid CamelCase: #1718: FILE: drivers/net/failsafe/failsafe_ops.c:614: + PRIu8 " with error %d", i, ret); CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i' - possible side-effects? #1928: FILE: drivers/net/failsafe/failsafe_private.h:155: +#define FOREACH_SUBDEV_ST(s, i, dev, state) \ + for (i = fs_find_next((dev), 0, state); \ + i < PRIV(dev)->subs_tail && (s = &PRIV(dev)->subs[i]); \ + i = fs_find_next((dev), i + 1, state)) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev' - possible side-effects? #1928: FILE: drivers/net/failsafe/failsafe_private.h:155: +#define FOREACH_SUBDEV_ST(s, i, dev, state) \ + for (i = fs_find_next((dev), 0, state); \ + i < PRIV(dev)->subs_tail && (s = &PRIV(dev)->subs[i]); \ + i = fs_find_next((dev), i + 1, state)) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'state' - possible side-effects? #1928: FILE: drivers/net/failsafe/failsafe_private.h:155: +#define FOREACH_SUBDEV_ST(s, i, dev, state) \ + for (i = fs_find_next((dev), 0, state); \ + i < PRIV(dev)->subs_tail && (s = &PRIV(dev)->subs[i]); \ + i = fs_find_next((dev), i + 1, state)) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev' - possible side-effects? #1947: FILE: drivers/net/failsafe/failsafe_private.h:174: +#define TX_SUBDEV(dev) \ + (PRIV(dev)->subs_tx >= PRIV(dev)->subs_tail ? NULL \ + : (PRIV(dev)->subs[PRIV(dev)->subs_tx].state < DEV_PROBED ? NULL \ + : &PRIV(dev)->subs[PRIV(dev)->subs_tx])) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'ops' may be better as '(ops)' to avoid precedence issues #1956: FILE: drivers/net/failsafe/failsafe_private.h:183: +#define SUBOPS(s, ops) \ + (ETH(s)->dev_ops->ops) total: 0 errors, 0 warnings, 1992 lines checked