From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 2663356A1; Wed, 12 Jul 2017 20:28:34 +0200 (CEST)
In-Reply-To: <20170712182812.18404-1-thomas@monjalon.net>
References: <20170712182812.18404-1-thomas@monjalon.net>
To: test-report@dpdk.org
Cc: Thomas Monjalon <thomas@monjalon.net>
Message-Id: <20170712182834.2663356A1@dpdk.org>
Date: Wed, 12 Jul 2017 20:28:34 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw26863 [PATCH] net/failsafe: do not
	probe device if plugged out
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Jul 2017 18:28:34 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/26863

_coding style issues_


ERROR:SPACING: space prohibited after that '!' (ctx:BxW)
#70: FILE: drivers/net/failsafe/failsafe_eal.c:73:
+		if (! first_init
 		    ^

CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#71: FILE: drivers/net/failsafe/failsafe_eal.c:74:
+		if (! first_init
+				&& sdev->cmdline == NULL

CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#72: FILE: drivers/net/failsafe/failsafe_eal.c:75:
+				&& sdev->cmdline == NULL
+				&& strcmp(da->bus->name, "vdev") != 0) {

total: 1 errors, 0 warnings, 2 checks, 45 lines checked