From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 541A57CA3; Sat, 15 Jul 2017 19:58:32 +0200 (CEST)
In-Reply-To: <7390b7f14a1925ece0c55c6b1df8da358c725017.1500130634.git.gaetan.rivet@6wind.com>
References: <7390b7f14a1925ece0c55c6b1df8da358c725017.1500130634.git.gaetan.rivet@6wind.com>
To: test-report@dpdk.org
Cc: Gaetan Rivet <gaetan.rivet@6wind.com>
Message-Id: <20170715175832.541A57CA3@dpdk.org>
Date: Sat, 15 Jul 2017 19:58:32 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw26955 [PATCH v10 03/11]
	net/failsafe: add fail-safe PMD
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sat, 15 Jul 2017 17:58:32 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/26955

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <PRIu8>
#1705: FILE: drivers/net/failsafe/failsafe_ops.c:615:
+			      PRIu8 " with error %d", i, ret);

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i' - possible side-effects?
#1915: FILE: drivers/net/failsafe/failsafe_private.h:155:
+#define FOREACH_SUBDEV_ST(s, i, dev, state)				\
+	for (i = fs_find_next((dev), 0, state);				\
+	     i < PRIV(dev)->subs_tail && (s = &PRIV(dev)->subs[i]);	\
+	     i = fs_find_next((dev), i + 1, state))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev' - possible side-effects?
#1915: FILE: drivers/net/failsafe/failsafe_private.h:155:
+#define FOREACH_SUBDEV_ST(s, i, dev, state)				\
+	for (i = fs_find_next((dev), 0, state);				\
+	     i < PRIV(dev)->subs_tail && (s = &PRIV(dev)->subs[i]);	\
+	     i = fs_find_next((dev), i + 1, state))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'state' - possible side-effects?
#1915: FILE: drivers/net/failsafe/failsafe_private.h:155:
+#define FOREACH_SUBDEV_ST(s, i, dev, state)				\
+	for (i = fs_find_next((dev), 0, state);				\
+	     i < PRIV(dev)->subs_tail && (s = &PRIV(dev)->subs[i]);	\
+	     i = fs_find_next((dev), i + 1, state))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev' - possible side-effects?
#1934: FILE: drivers/net/failsafe/failsafe_private.h:174:
+#define TX_SUBDEV(dev)							  \
+	(PRIV(dev)->subs_tx >= PRIV(dev)->subs_tail		   ? NULL \
+	 : (PRIV(dev)->subs[PRIV(dev)->subs_tx].state < DEV_PROBED ? NULL \
+	 : &PRIV(dev)->subs[PRIV(dev)->subs_tx]))

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'ops' may be better as '(ops)' to avoid precedence issues
#1943: FILE: drivers/net/failsafe/failsafe_private.h:183:
+#define SUBOPS(s, ops) \
+	(ETH(s)->dev_ops->ops)

total: 0 errors, 0 warnings, 1962 lines checked