From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Subject: [dpdk-test-report] |WARNING| pw27356 [PATCH v1 42/48] net/mlx4: separate device control functions
Date: Tue, 1 Aug 2017 19:05:54 +0200 (CEST) [thread overview]
Message-ID: <20170801170554.B689FA13C@dpdk.org> (raw)
In-Reply-To: <d85e05d19b89463bc32f94f0ca17f1edb35e3db8.1501598384.git.adrien.mazarguil@6wind.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/27356
_coding style issues_
WARNING:FUNCTION_ARGUMENTS: function definition argument 'char' should also have an identifier name
#884: FILE: drivers/net/mlx4/mlx4.h:124:
+int mlx4_get_ifname(const struct priv *priv, char (*ifname)[IF_NAMESIZE]);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint8_t' should also have an identifier name
#885: FILE: drivers/net/mlx4/mlx4.h:125:
+int mlx4_get_mac(struct priv *priv, uint8_t (*mac)[ETHER_ADDR_LEN]);
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'name' - possible side-effects?
#1719: FILE: drivers/net/mlx4/mlx4_utils.h:96:
+#define MKSTR(name, ...) \
+ char name[snprintf(NULL, 0, __VA_ARGS__) + 1]; \
+ \
+ snprintf(name, sizeof(name), __VA_ARGS__)
total: 0 errors, 2 warnings, 1 checks, 1663 lines checked
parent reply other threads:[~2017-08-01 17:05 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <d85e05d19b89463bc32f94f0ca17f1edb35e3db8.1501598384.git.adrien.mazarguil@6wind.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170801170554.B689FA13C@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=adrien.mazarguil@6wind.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).