From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id B689FA13C; Tue,  1 Aug 2017 19:05:54 +0200 (CEST)
In-Reply-To: <d85e05d19b89463bc32f94f0ca17f1edb35e3db8.1501598384.git.adrien.mazarguil@6wind.com>
References: <d85e05d19b89463bc32f94f0ca17f1edb35e3db8.1501598384.git.adrien.mazarguil@6wind.com>
To: test-report@dpdk.org
Cc: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Message-Id: <20170801170554.B689FA13C@dpdk.org>
Date: Tue,  1 Aug 2017 19:05:54 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw27356 [PATCH v1 42/48] net/mlx4:
	separate device control functions
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Aug 2017 17:05:55 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/27356

_coding style issues_


WARNING:FUNCTION_ARGUMENTS: function definition argument 'char' should also have an identifier name
#884: FILE: drivers/net/mlx4/mlx4.h:124:
+int mlx4_get_ifname(const struct priv *priv, char (*ifname)[IF_NAMESIZE]);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint8_t' should also have an identifier name
#885: FILE: drivers/net/mlx4/mlx4.h:125:
+int mlx4_get_mac(struct priv *priv, uint8_t (*mac)[ETHER_ADDR_LEN]);

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'name' - possible side-effects?
#1719: FILE: drivers/net/mlx4/mlx4_utils.h:96:
+#define MKSTR(name, ...) \
+	char name[snprintf(NULL, 0, __VA_ARGS__) + 1]; \
+	\
+	snprintf(name, sizeof(name), __VA_ARGS__)

total: 0 errors, 2 warnings, 1 checks, 1663 lines checked