automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
Subject: [dpdk-test-report] |WARNING| pw27366 [PATCH v1] net/mlx5: support RSS hash configuration in generic flow action
Date: Wed,  2 Aug 2017 16:11:45 +0200 (CEST)	[thread overview]
Message-ID: <20170802141145.0B6AAA257@dpdk.org> (raw)
In-Reply-To: <56a0399bee0499c0ae85425ddf7f5149002cfee9.1501681913.git.nelio.laranjeiro@6wind.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/27366

_coding style issues_


WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#262: FILE: drivers/net/mlx5/mlx5_flow.c:1108:
+		return ENOMEM;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#329: FILE: drivers/net/mlx5/mlx5_flow.c:1175:
+			return ENOMEM;

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#399: FILE: drivers/net/mlx5/mlx5_flow.c:1247:
+		      (void*)rte_flow, i, (void*)rte_flow->hrxqs[i],

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#399: FILE: drivers/net/mlx5/mlx5_flow.c:1247:
+		      (void*)rte_flow, i, (void*)rte_flow->hrxqs[i],

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#400: FILE: drivers/net/mlx5/mlx5_flow.c:1248:
+		      (void*)rte_flow->ibv_flows[i]);

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#497: FILE: drivers/net/mlx5/mlx5_flow.c:1416:
+			      (void*)flow, i, (void*)flow->hrxqs[i],

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#497: FILE: drivers/net/mlx5/mlx5_flow.c:1416:
+			      (void*)flow, i, (void*)flow->hrxqs[i],

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#498: FILE: drivers/net/mlx5/mlx5_flow.c:1417:
+			      (void*)flow->ibv_flows[i]);

WARNING:BRACES: braces {} are not necessary for single statement blocks
#565: FILE: drivers/net/mlx5/mlx5_flow.c:1564:
+				for (n = 0; n < queues_n; ++n) {
+					(*priv->rxqs)[queues[n]]->mark = 1;
+				}

total: 6 errors, 3 warnings, 0 checks, 599 lines checked

           reply	other threads:[~2017-08-02 14:11 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <56a0399bee0499c0ae85425ddf7f5149002cfee9.1501681913.git.nelio.laranjeiro@6wind.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170802141145.0B6AAA257@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=nelio.laranjeiro@6wind.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).