From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 1063AA2B1; Wed,  2 Aug 2017 16:11:59 +0200 (CEST)
In-Reply-To: <1aabdbe993975be19a13da75fa1522aff636deca.1501681927.git.nelio.laranjeiro@6wind.com>
References: <1aabdbe993975be19a13da75fa1522aff636deca.1501681927.git.nelio.laranjeiro@6wind.com>
To: test-report@dpdk.org
Cc: =?utf-8?q?N=C3=A9lio_Laranjeiro?= <nelio.laranjeiro@6wind.com>
Message-Id: <20170802141159.1063AA2B1@dpdk.org>
Date: Wed,  2 Aug 2017 16:11:59 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw27373 [PATCH v1 07/21] net/mlx5: add
	reference counter on memory region
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Aug 2017 14:11:59 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/27373

_coding style issues_


ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#46: FILE: drivers/net/mlx5/mlx5.h:295:
+struct mlx5_mr* priv_mr_new(struct priv *, struct rte_mempool *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name
#46: FILE: drivers/net/mlx5/mlx5.h:295:
+struct mlx5_mr* priv_mr_new(struct priv *, struct rte_mempool *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct rte_mempool *' should also have an identifier name
#46: FILE: drivers/net/mlx5/mlx5.h:295:
+struct mlx5_mr* priv_mr_new(struct priv *, struct rte_mempool *);

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#47: FILE: drivers/net/mlx5/mlx5.h:296:
+struct mlx5_mr* priv_mr_get(struct priv *, struct rte_mempool *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name
#47: FILE: drivers/net/mlx5/mlx5.h:296:
+struct mlx5_mr* priv_mr_get(struct priv *, struct rte_mempool *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct rte_mempool *' should also have an identifier name
#47: FILE: drivers/net/mlx5/mlx5.h:296:
+struct mlx5_mr* priv_mr_get(struct priv *, struct rte_mempool *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name
#48: FILE: drivers/net/mlx5/mlx5.h:297:
+int priv_mr_release(struct priv *, struct mlx5_mr *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct mlx5_mr *' should also have an identifier name
#48: FILE: drivers/net/mlx5/mlx5.h:297:
+int priv_mr_release(struct priv *, struct mlx5_mr *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name
#49: FILE: drivers/net/mlx5/mlx5.h:298:
+int priv_mr_verify(struct priv *);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EBUSY)
#284: FILE: drivers/net/mlx5/mlx5_mr.c:344:
+	return EBUSY;

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#302: FILE: drivers/net/mlx5/mlx5_mr.c:362:
+		DEBUG("%p: mr %p still referenced", (void*)priv,

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#303: FILE: drivers/net/mlx5/mlx5_mr.c:363:
+		      (void*)mr);

total: 4 errors, 8 warnings, 0 checks, 404 lines checked