From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 677B79B8B; Wed,  2 Aug 2017 16:12:06 +0200 (CEST)
In-Reply-To: <760f11c2808a68210333ab6721e96e3eb9348c1e.1501681927.git.nelio.laranjeiro@6wind.com>
References: <760f11c2808a68210333ab6721e96e3eb9348c1e.1501681927.git.nelio.laranjeiro@6wind.com>
To: test-report@dpdk.org
Cc: =?utf-8?q?N=C3=A9lio_Laranjeiro?= <nelio.laranjeiro@6wind.com>
Message-Id: <20170802141206.677B79B8B@dpdk.org>
Date: Wed,  2 Aug 2017 16:12:06 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw27376 [PATCH v1 10/21] net/mlx5: add
	reference counter on DPDK Tx queues
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Aug 2017 14:12:06 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/27376

_coding style issues_


ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#55: FILE: drivers/net/mlx5/mlx5.c:202:
+		WARN("%p: some Tx Queues still remain", (void*)priv);

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#169: FILE: drivers/net/mlx5/mlx5_rxtx.h:350:
+struct mlx5_txq_ctrl* mlx5_priv_txq_new(struct priv *priv, uint16_t idx,

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#171: FILE: drivers/net/mlx5/mlx5_rxtx.h:352:
+struct mlx5_txq_ctrl* mlx5_priv_txq_get(struct priv *priv, uint16_t idx);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name
#174: FILE: drivers/net/mlx5/mlx5_rxtx.h:355:
+int mlx5_priv_txq_verify(struct priv *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct rte_mempool *' should also have an identifier name
#184: FILE: drivers/net/mlx5/mlx5_rxtx.h:384:
+void mlx5_mp2mr_iter(struct rte_mempool *, void *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'void *' should also have an identifier name
#184: FILE: drivers/net/mlx5/mlx5_rxtx.h:384:
+void mlx5_mp2mr_iter(struct rte_mempool *, void *);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EBUSY)
#676: FILE: drivers/net/mlx5/mlx5_txq.c:654:
+	return EBUSY;

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#716: FILE: drivers/net/mlx5/mlx5_txq.c:694:
+		DEBUG("%p: Tx Queue %p still referenced", (void*)priv,

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#717: FILE: drivers/net/mlx5/mlx5_txq.c:695:
+		      (void*)txq);

total: 5 errors, 4 warnings, 0 checks, 652 lines checked