automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
Subject: [dpdk-test-report] |WARNING| pw27380 [PATCH v1 14/21] net/mlx5: add Hash Rx queue object
Date: Wed,  2 Aug 2017 16:12:15 +0200 (CEST)	[thread overview]
Message-ID: <20170802141215.3EAEFA16A@dpdk.org> (raw)
In-Reply-To: <77dd76fe2b05830a85911e708095d88299969607.1501681927.git.nelio.laranjeiro@6wind.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/27380

_coding style issues_


ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#33: FILE: drivers/net/mlx5/mlx5.c:187:
+		WARN("%p: some Hash Rx queue still remain", (void*)priv);

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#323: FILE: drivers/net/mlx5/mlx5_rxq.c:1755:
+	DEBUG("%p: Hash Rx queue %p: refcnt %d", (void*)priv,

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#324: FILE: drivers/net/mlx5/mlx5_rxq.c:1756:
+	      (void*)hrxq, rte_atomic32_read(&hrxq->refcnt));

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#363: FILE: drivers/net/mlx5/mlx5_rxq.c:1795:
+		DEBUG("%p: Hash Rx queue %p: refcnt %d", (void*)priv,

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#364: FILE: drivers/net/mlx5/mlx5_rxq.c:1796:
+		      (void*)hrxq, rte_atomic32_read(&hrxq->refcnt));

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#384: FILE: drivers/net/mlx5/mlx5_rxq.c:1816:
+	DEBUG("%p: Hash Rx queue %p: refcnt %d", (void*)priv,

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#385: FILE: drivers/net/mlx5/mlx5_rxq.c:1817:
+	      (void*)hrxq, rte_atomic32_read(&hrxq->refcnt));

WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#392: FILE: drivers/net/mlx5/mlx5_rxq.c:1824:
+		return 0;
+	} else {

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EBUSY)
#396: FILE: drivers/net/mlx5/mlx5_rxq.c:1828:
+	return EBUSY;

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#415: FILE: drivers/net/mlx5/mlx5_rxq.c:1847:
+		      (void*)priv, (void*)hrxq);

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#415: FILE: drivers/net/mlx5/mlx5_rxq.c:1847:
+		      (void*)priv, (void*)hrxq);

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#446: FILE: drivers/net/mlx5/mlx5_rxtx.h:377:
+struct mlx5_hrxq* mlx5_priv_hrxq_new(struct priv *priv, uint8_t *rss_key,

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#449: FILE: drivers/net/mlx5/mlx5_rxtx.h:380:
+struct mlx5_hrxq* mlx5_priv_hrxq_get(struct priv *priv, uint8_t *rss_key,

total: 11 errors, 2 warnings, 0 checks, 403 lines checked

           reply	other threads:[~2017-08-02 14:12 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <77dd76fe2b05830a85911e708095d88299969607.1501681927.git.nelio.laranjeiro@6wind.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170802141215.3EAEFA16A@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=nelio.laranjeiro@6wind.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).