From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 3EAEFA16A; Wed,  2 Aug 2017 16:12:15 +0200 (CEST)
In-Reply-To: <77dd76fe2b05830a85911e708095d88299969607.1501681927.git.nelio.laranjeiro@6wind.com>
References: <77dd76fe2b05830a85911e708095d88299969607.1501681927.git.nelio.laranjeiro@6wind.com>
To: test-report@dpdk.org
Cc: =?utf-8?q?N=C3=A9lio_Laranjeiro?= <nelio.laranjeiro@6wind.com>
Message-Id: <20170802141215.3EAEFA16A@dpdk.org>
Date: Wed,  2 Aug 2017 16:12:15 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw27380 [PATCH v1 14/21] net/mlx5: add
	Hash Rx queue object
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Aug 2017 14:12:15 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/27380

_coding style issues_


ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#33: FILE: drivers/net/mlx5/mlx5.c:187:
+		WARN("%p: some Hash Rx queue still remain", (void*)priv);

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#323: FILE: drivers/net/mlx5/mlx5_rxq.c:1755:
+	DEBUG("%p: Hash Rx queue %p: refcnt %d", (void*)priv,

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#324: FILE: drivers/net/mlx5/mlx5_rxq.c:1756:
+	      (void*)hrxq, rte_atomic32_read(&hrxq->refcnt));

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#363: FILE: drivers/net/mlx5/mlx5_rxq.c:1795:
+		DEBUG("%p: Hash Rx queue %p: refcnt %d", (void*)priv,

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#364: FILE: drivers/net/mlx5/mlx5_rxq.c:1796:
+		      (void*)hrxq, rte_atomic32_read(&hrxq->refcnt));

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#384: FILE: drivers/net/mlx5/mlx5_rxq.c:1816:
+	DEBUG("%p: Hash Rx queue %p: refcnt %d", (void*)priv,

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#385: FILE: drivers/net/mlx5/mlx5_rxq.c:1817:
+	      (void*)hrxq, rte_atomic32_read(&hrxq->refcnt));

WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#392: FILE: drivers/net/mlx5/mlx5_rxq.c:1824:
+		return 0;
+	} else {

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EBUSY)
#396: FILE: drivers/net/mlx5/mlx5_rxq.c:1828:
+	return EBUSY;

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#415: FILE: drivers/net/mlx5/mlx5_rxq.c:1847:
+		      (void*)priv, (void*)hrxq);

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#415: FILE: drivers/net/mlx5/mlx5_rxq.c:1847:
+		      (void*)priv, (void*)hrxq);

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#446: FILE: drivers/net/mlx5/mlx5_rxtx.h:377:
+struct mlx5_hrxq* mlx5_priv_hrxq_new(struct priv *priv, uint8_t *rss_key,

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#449: FILE: drivers/net/mlx5/mlx5_rxtx.h:380:
+struct mlx5_hrxq* mlx5_priv_hrxq_get(struct priv *priv, uint8_t *rss_key,

total: 11 errors, 2 warnings, 0 checks, 403 lines checked