From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 1017) id 36217A1EC; Wed, 2 Aug 2017 16:12:18 +0200 (CEST) In-Reply-To: <0846f9b9abec4d46289a8f987b694f64b54cfad8.1501681927.git.nelio.laranjeiro@6wind.com> References: <0846f9b9abec4d46289a8f987b694f64b54cfad8.1501681927.git.nelio.laranjeiro@6wind.com> To: test-report@dpdk.org Cc: =?utf-8?q?N=C3=A9lio_Laranjeiro?= Message-Id: <20170802141218.36217A1EC@dpdk.org> Date: Wed, 2 Aug 2017 16:12:18 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw27382 [PATCH v1 16/21] net/mlx5: use flow to enable promiscuous mode X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2017 14:12:18 -0000 Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/27382 _coding style issues_ WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name #86: FILE: drivers/net/mlx5/mlx5.h:296: +void priv_flow_flush(struct priv *, struct mlx5_flows *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct mlx5_flows *' should also have an identifier name #86: FILE: drivers/net/mlx5/mlx5.h:296: +void priv_flow_flush(struct priv *, struct mlx5_flows *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name #91: FILE: drivers/net/mlx5/mlx5.h:299: +int priv_flow_start(struct priv *, struct mlx5_flows *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct mlx5_flows *' should also have an identifier name #91: FILE: drivers/net/mlx5/mlx5.h:299: +int priv_flow_start(struct priv *, struct mlx5_flows *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct priv *' should also have an identifier name #92: FILE: drivers/net/mlx5/mlx5.h:300: +void priv_flow_stop(struct priv *, struct mlx5_flows *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct mlx5_flows *' should also have an identifier name #92: FILE: drivers/net/mlx5/mlx5.h:300: +void priv_flow_stop(struct priv *, struct mlx5_flows *); WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct rte_eth_dev *' should also have an identifier name #94: FILE: drivers/net/mlx5/mlx5.h:302: +int mlx5_flow_ctrl(struct rte_eth_dev *, struct rte_flow_item_eth *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct rte_flow_item_eth *' should also have an identifier name #94: FILE: drivers/net/mlx5/mlx5.h:302: +int mlx5_flow_ctrl(struct rte_eth_dev *, struct rte_flow_item_eth *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct rte_flow_item_eth *' should also have an identifier name #94: FILE: drivers/net/mlx5/mlx5.h:302: +int mlx5_flow_ctrl(struct rte_eth_dev *, struct rte_flow_item_eth *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'unsigned int' should also have an identifier name #94: FILE: drivers/net/mlx5/mlx5.h:302: +int mlx5_flow_ctrl(struct rte_eth_dev *, struct rte_flow_item_eth *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'unsigned int' should also have an identifier name #94: FILE: drivers/net/mlx5/mlx5.h:302: +int mlx5_flow_ctrl(struct rte_eth_dev *, struct rte_flow_item_eth *, WARNING:BRACES: braces {} are not necessary for single statement blocks #277: FILE: drivers/net/mlx5/mlx5_flow.c:1450: + if (!flow) { + return 1; + } WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 15) #466: FILE: drivers/net/mlx5/mlx5_trigger.c:168: + if (dev->data->promiscuous) + mlx5_promiscuous_enable(dev); total: 0 errors, 13 warnings, 0 checks, 421 lines checked