From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 1FE73A122; Wed,  2 Aug 2017 16:17:26 +0200 (CEST)
In-Reply-To: <56a0399bee0499c0ae85425ddf7f5149002cfee9.1501681927.git.nelio.laranjeiro@6wind.com>
References: <56a0399bee0499c0ae85425ddf7f5149002cfee9.1501681927.git.nelio.laranjeiro@6wind.com>
To: test-report@dpdk.org
Cc: =?utf-8?q?N=C3=A9lio_Laranjeiro?= <nelio.laranjeiro@6wind.com>
Message-Id: <20170802141726.1FE73A122@dpdk.org>
Date: Wed,  2 Aug 2017 16:17:26 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw27387 [PATCH v1 21/21] net/mlx5:
	support RSS hash configuration in generic flow action
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Aug 2017 14:17:26 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/27387

_coding style issues_


WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#262: FILE: drivers/net/mlx5/mlx5_flow.c:1108:
+		return ENOMEM;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#329: FILE: drivers/net/mlx5/mlx5_flow.c:1175:
+			return ENOMEM;

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#399: FILE: drivers/net/mlx5/mlx5_flow.c:1247:
+		      (void*)rte_flow, i, (void*)rte_flow->hrxqs[i],

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#399: FILE: drivers/net/mlx5/mlx5_flow.c:1247:
+		      (void*)rte_flow, i, (void*)rte_flow->hrxqs[i],

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#400: FILE: drivers/net/mlx5/mlx5_flow.c:1248:
+		      (void*)rte_flow->ibv_flows[i]);

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#497: FILE: drivers/net/mlx5/mlx5_flow.c:1416:
+			      (void*)flow, i, (void*)flow->hrxqs[i],

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#497: FILE: drivers/net/mlx5/mlx5_flow.c:1416:
+			      (void*)flow, i, (void*)flow->hrxqs[i],

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#498: FILE: drivers/net/mlx5/mlx5_flow.c:1417:
+			      (void*)flow->ibv_flows[i]);

WARNING:BRACES: braces {} are not necessary for single statement blocks
#565: FILE: drivers/net/mlx5/mlx5_flow.c:1564:
+				for (n = 0; n < queues_n; ++n) {
+					(*priv->rxqs)[queues[n]]->mark = 1;
+				}

total: 6 errors, 3 warnings, 0 checks, 599 lines checked