From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Vasily Philipov <vasilyf@mellanox.com>
Subject: [dpdk-test-report] |WARNING| pw27399 [PATCH 1/2] net/mlx4: get back RX flow functionality
Date: Thu, 3 Aug 2017 10:51:17 +0200 (CEST) [thread overview]
Message-ID: <20170803085117.4127447CD@dpdk.org> (raw)
In-Reply-To: <fa8e5827c13923dd42fa54405c9b1069adcf718a.1501749963.git.vasilyf@mellanox.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/27399
_coding style issues_
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'val' - possible side-effects?
#119: FILE: drivers/net/mlx4/mlx4_prm.h:56:
+#define MLX4_TRANSPOSE(val, from, to) \
+ (((from) >= (to)) ? \
+ (((val) & (from)) / ((from) / (to))) : \
+ (((val) & (from)) * ((to) / (from))))
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'from' - possible side-effects?
#119: FILE: drivers/net/mlx4/mlx4_prm.h:56:
+#define MLX4_TRANSPOSE(val, from, to) \
+ (((from) >= (to)) ? \
+ (((val) & (from)) / ((from) / (to))) : \
+ (((val) & (from)) * ((to) / (from))))
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'to' - possible side-effects?
#119: FILE: drivers/net/mlx4/mlx4_prm.h:56:
+#define MLX4_TRANSPOSE(val, from, to) \
+ (((from) >= (to)) ? \
+ (((val) & (from)) / ((from) / (to))) : \
+ (((val) & (from)) * ((to) / (from))))
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#334: FILE: drivers/net/mlx4/mlx4_prm.h:271:
+ unsigned max_post;
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#336: FILE: drivers/net/mlx4/mlx4_prm.h:273:
+ unsigned head;
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#337: FILE: drivers/net/mlx4/mlx4_prm.h:274:
+ unsigned tail;
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#340: FILE: drivers/net/mlx4/mlx4_prm.h:277:
+ unsigned head_en_index;
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#341: FILE: drivers/net/mlx4/mlx4_prm.h:278:
+ unsigned head_en_count;
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#373: FILE: drivers/net/mlx4/mlx4_prm.h:310:
+ unsigned last_db_head;
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'xxx' may be better as '(xxx)' to avoid precedence issues
#448: FILE: drivers/net/mlx4/mlx4_prm.h:385:
+#define to_mxxx(xxx, type) \
+ ((struct mlx4_##type *) \
+ ((uint8_t *)ib##xxx - offsetof(struct mlx4_##type, ibv_##xxx)))
CHECK:BRACES: Unbalanced braces around else statement
#512: FILE: drivers/net/mlx4/mlx4_rxq.c:104:
+ } else
total: 0 errors, 6 warnings, 5 checks, 1079 lines checked
parent reply other threads:[~2017-08-03 8:51 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <fa8e5827c13923dd42fa54405c9b1069adcf718a.1501749963.git.vasilyf@mellanox.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170803085117.4127447CD@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=test-report@dpdk.org \
--cc=vasilyf@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).