From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 4127447CD; Thu,  3 Aug 2017 10:51:17 +0200 (CEST)
In-Reply-To: <fa8e5827c13923dd42fa54405c9b1069adcf718a.1501749963.git.vasilyf@mellanox.com>
References: <fa8e5827c13923dd42fa54405c9b1069adcf718a.1501749963.git.vasilyf@mellanox.com>
To: test-report@dpdk.org
Cc: Vasily Philipov <vasilyf@mellanox.com>
Message-Id: <20170803085117.4127447CD@dpdk.org>
Date: Thu,  3 Aug 2017 10:51:17 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw27399 [PATCH 1/2] net/mlx4: get back
	RX flow functionality
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Aug 2017 08:51:17 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/27399

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'val' - possible side-effects?
#119: FILE: drivers/net/mlx4/mlx4_prm.h:56:
+#define MLX4_TRANSPOSE(val, from, to) \
+	(((from) >= (to)) ? \
+	 (((val) & (from)) / ((from) / (to))) : \
+	 (((val) & (from)) * ((to) / (from))))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'from' - possible side-effects?
#119: FILE: drivers/net/mlx4/mlx4_prm.h:56:
+#define MLX4_TRANSPOSE(val, from, to) \
+	(((from) >= (to)) ? \
+	 (((val) & (from)) / ((from) / (to))) : \
+	 (((val) & (from)) * ((to) / (from))))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'to' - possible side-effects?
#119: FILE: drivers/net/mlx4/mlx4_prm.h:56:
+#define MLX4_TRANSPOSE(val, from, to) \
+	(((from) >= (to)) ? \
+	 (((val) & (from)) / ((from) / (to))) : \
+	 (((val) & (from)) * ((to) / (from))))

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#334: FILE: drivers/net/mlx4/mlx4_prm.h:271:
+	unsigned         max_post;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#336: FILE: drivers/net/mlx4/mlx4_prm.h:273:
+	unsigned         head;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#337: FILE: drivers/net/mlx4/mlx4_prm.h:274:
+	unsigned         tail;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#340: FILE: drivers/net/mlx4/mlx4_prm.h:277:
+	unsigned         head_en_index;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#341: FILE: drivers/net/mlx4/mlx4_prm.h:278:
+	unsigned         head_en_count;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#373: FILE: drivers/net/mlx4/mlx4_prm.h:310:
+	unsigned              last_db_head;

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'xxx' may be better as '(xxx)' to avoid precedence issues
#448: FILE: drivers/net/mlx4/mlx4_prm.h:385:
+#define to_mxxx(xxx, type) \
+	((struct mlx4_##type *)	\
+	 ((uint8_t *)ib##xxx - offsetof(struct mlx4_##type, ibv_##xxx)))

CHECK:BRACES: Unbalanced braces around else statement
#512: FILE: drivers/net/mlx4/mlx4_rxq.c:104:
+		} else

total: 0 errors, 6 warnings, 5 checks, 1079 lines checked