* [dpdk-test-report] |WARNING| pw27524 [PATCH] kni: fix SLE version detection
[not found] <20170811163314.32657-1-ndas@suse.de>
@ 2017-08-11 16:33 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2017-08-11 16:33 UTC (permalink / raw)
To: test-report; +Cc: Nirmoy Das
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/27524
_coding style issues_
WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#36: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:700:
+#if (LINUX_VERSION_CODE >= KERNEL_VERSION(4, 4, 57))
ERROR:SPACING: space required after that ',' (ctx:VxV)
#39: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:703:
+#elif ( LINUX_VERSION_CODE >= KERNEL_VERSION(3,12,28) )
^
ERROR:SPACING: space required after that ',' (ctx:VxV)
#39: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:703:
+#elif ( LINUX_VERSION_CODE >= KERNEL_VERSION(3,12,28) )
^
ERROR:SPACING: space prohibited after that open parenthesis '('
#39: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:703:
+#elif ( LINUX_VERSION_CODE >= KERNEL_VERSION(3,12,28) )
ERROR:SPACING: space prohibited before that close parenthesis ')'
#39: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:703:
+#elif ( LINUX_VERSION_CODE >= KERNEL_VERSION(3,12,28) )
WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#39: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:703:
+#elif ( LINUX_VERSION_CODE >= KERNEL_VERSION(3,12,28) )
ERROR:SPACING: space required after that ',' (ctx:VxV)
#41: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:705:
+#define SLE_VERSION_CODE SLE_VERSION(12,0,0)
^
ERROR:SPACING: space required after that ',' (ctx:VxV)
#41: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:705:
+#define SLE_VERSION_CODE SLE_VERSION(12,0,0)
^
ERROR:SPACING: space required after that ',' (ctx:VxV)
#52: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:710:
+#elif ( LINUX_VERSION_CODE == KERNEL_VERSION(2,6,32) )
^
ERROR:SPACING: space required after that ',' (ctx:VxV)
#52: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:710:
+#elif ( LINUX_VERSION_CODE == KERNEL_VERSION(2,6,32) )
^
ERROR:SPACING: space prohibited after that open parenthesis '('
#52: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:710:
+#elif ( LINUX_VERSION_CODE == KERNEL_VERSION(2,6,32) )
ERROR:SPACING: space prohibited before that close parenthesis ')'
#52: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:710:
+#elif ( LINUX_VERSION_CODE == KERNEL_VERSION(2,6,32) )
WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#52: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:710:
+#elif ( LINUX_VERSION_CODE == KERNEL_VERSION(2,6,32) )
ERROR:SPACING: space required after that ',' (ctx:VxV)
#54: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:712:
+#define SLE_VERSION_CODE SLE_VERSION(11,1,0)
^
ERROR:SPACING: space required after that ',' (ctx:VxV)
#54: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:712:
+#define SLE_VERSION_CODE SLE_VERSION(11,1,0)
^
ERROR:SPACING: space required after that ',' (ctx:VxV)
#55: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:713:
+#elif ( LINUX_VERSION_CODE == KERNEL_VERSION(2,6,27) )
^
ERROR:SPACING: space required after that ',' (ctx:VxV)
#55: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:713:
+#elif ( LINUX_VERSION_CODE == KERNEL_VERSION(2,6,27) )
^
ERROR:SPACING: space prohibited after that open parenthesis '('
#55: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:713:
+#elif ( LINUX_VERSION_CODE == KERNEL_VERSION(2,6,27) )
ERROR:SPACING: space prohibited before that close parenthesis ')'
#55: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:713:
+#elif ( LINUX_VERSION_CODE == KERNEL_VERSION(2,6,27) )
WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#55: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:713:
+#elif ( LINUX_VERSION_CODE == KERNEL_VERSION(2,6,27) )
ERROR:SPACING: space required after that ',' (ctx:VxV)
#57: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:715:
+#define SLE_VERSION_CODE SLE_VERSION(11,0,0)
^
ERROR:SPACING: space required after that ',' (ctx:VxV)
#57: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:715:
+#define SLE_VERSION_CODE SLE_VERSION(11,0,0)
^
total: 18 errors, 4 warnings, 34 lines checked
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2017-08-11 16:33 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20170811163314.32657-1-ndas@suse.de>
2017-08-11 16:33 ` [dpdk-test-report] |WARNING| pw27524 [PATCH] kni: fix SLE version detection checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).