From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id AE1CD7D9B; Mon, 14 Aug 2017 17:17:31 +0200 (CEST)
In-Reply-To: <20170814151537.29454-2-santosh.shukla@caviumnetworks.com>
References: <20170814151537.29454-2-santosh.shukla@caviumnetworks.com>
To: test-report@dpdk.org
Cc: Santosh Shukla <santosh.shukla@caviumnetworks.com>
Message-Id: <20170814151731.AE1CD7D9B@dpdk.org>
Date: Mon, 14 Aug 2017 17:17:31 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw27577 [PATCH v1 1/4] eal: rename
	phys_addr_t to iova_addr_t
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 14 Aug 2017 15:17:31 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/27577

_coding style issues_


CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'sc' may be better as '(sc)' to avoid precedence issues
#701: FILE: drivers/net/bnx2x/bnx2x.h:1245:
+#define GUNZIP_PHYS(sc)   (iova_addr_t)(sc->gz_buf_dma.paddr)

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#728: FILE: drivers/net/bnx2x/bnx2x.h:1405:
+    iova_addr_t fw_stat_map; /* (dma) valid if FUNC_FLG_STATS */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#729: FILE: drivers/net/bnx2x/bnx2x.h:1406:
+    iova_addr_t spq_map;     /* (dma) valid if FUNC_FLG_SPQ */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#766: FILE: drivers/net/bnx2x/bnx2x_stats.c:1341:
+    iova_addr_t cur_data_offset;$

WARNING:LONG_LINE: line over 90 characters
#1279: FILE: drivers/net/xenvirt/rte_xen_lib.c:358:
+grant_node_create(uint32_t pg_num, uint32_t *gref_arr, iova_addr_t *pa_arr, char *val_str, size_t str_size)

WARNING:LONG_LINE: line over 90 characters
#1288: FILE: drivers/net/xenvirt/rte_xen_lib.c:422:
+grant_gntalloc_mbuf_pool(struct rte_mempool *mpool, uint32_t pg_num, uint32_t *gref_arr, iova_addr_t *pa_arr, int mempool_idx)

WARNING:LONG_LINE: line over 90 characters
#1319: FILE: drivers/net/xenvirt/rte_xen_lib.h:111:
+int grant_node_create(uint32_t pg_num, uint32_t *gref_arr, iova_addr_t *pa_arr, char *val_str, size_t str_size);

WARNING:LONG_LINE: line over 90 characters
#1323: FILE: drivers/net/xenvirt/rte_xen_lib.h:114:
+grant_gntalloc_mbuf_pool(struct rte_mempool *mpool, uint32_t pg_num, uint32_t *gref_arr, iova_addr_t *pa_arr, int mempool_idx);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'int32_t' should also have an identifier name
#1467: FILE: lib/librte_eal/common/include/rte_memory.h:204:
+iova_addr_t rte_xen_mem_phy2mch(int32_t, const iova_addr_t);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'const iova_addr_t' should also have an identifier name
#1467: FILE: lib/librte_eal/common/include/rte_memory.h:204:
+iova_addr_t rte_xen_mem_phy2mch(int32_t, const iova_addr_t);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'iova_addr_t' should also have an identifier name
#1633: FILE: lib/librte_mbuf/rte_mbuf.h:414:
+	iova_addr_t buf_physaddr __rte_aligned(sizeof(iova_addr_t));

total: 0 errors, 10 warnings, 1355 lines checked