automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Subject: [dpdk-test-report] |WARNING| pw27756 [PATCH 1/4] meter: add meter configuration profile
Date: Fri, 25 Aug 2017 12:26:37 +0200 (CEST)	[thread overview]
Message-ID: <20170825102637.B7D007D36@dpdk.org> (raw)
In-Reply-To: <1503488186-90047-2-git-send-email-cristian.dumitrescu@intel.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/27756

_coding style issues_


WARNING:LONG_LINE: line over 90 characters
#39: FILE: lib/librte_meter/rte_meter.c:63:
+rte_meter_srtcm_profile_config(struct rte_meter_srtcm_profile *p, struct rte_meter_srtcm_params *params)

WARNING:LONG_LINE: line over 90 characters
#60: FILE: lib/librte_meter/rte_meter.c:77:
+	rte_meter_get_tb_params(hz, params->cir, &p->cir_period, &p->cir_bytes_per_period);

WARNING:LONG_LINE: line over 90 characters
#90: FILE: lib/librte_meter/rte_meter.c:98:
+rte_meter_trtcm_profile_config(struct rte_meter_trtcm_profile *p, struct rte_meter_trtcm_params *params)

WARNING:LONG_LINE: line over 90 characters
#115: FILE: lib/librte_meter/rte_meter.c:115:
+	rte_meter_get_tb_params(hz, params->cir, &p->cir_period, &p->cir_bytes_per_period);

WARNING:LONG_LINE: line over 90 characters
#116: FILE: lib/librte_meter/rte_meter.c:116:
+	rte_meter_get_tb_params(hz, params->pir, &p->pir_period, &p->pir_bytes_per_period);

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#170: FILE: lib/librte_meter/rte_meter.h:92:
+/**
+  * Internal data structure storing the trTCM configuration profile. Typically

WARNING:LONG_LINE_COMMENT: line over 90 characters
#317: FILE: lib/librte_meter/rte_meter.h:251:
+	uint64_t cir_period; /* Number of CPU cycles for one update of C and E token buckets */

WARNING:LONG_LINE_COMMENT: line over 90 characters
#318: FILE: lib/librte_meter/rte_meter.h:252:
+	uint64_t cir_bytes_per_period; /* Number of bytes to add to C and E token buckets on each update */

WARNING:LONG_LINE_COMMENT: line over 90 characters
#350: FILE: lib/librte_meter/rte_meter.h:275:
+	uint64_t tc;      /* Number of bytes currently available in the committed (C) token bucket */

WARNING:LONG_LINE_COMMENT: line over 90 characters
#351: FILE: lib/librte_meter/rte_meter.h:276:
+	uint64_t tp;      /* Number of bytes currently available in the peak (P) token bucket */

total: 0 errors, 10 warnings, 457 lines checked

           reply	other threads:[~2017-08-25 10:26 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1503488186-90047-2-git-send-email-cristian.dumitrescu@intel.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170825102637.B7D007D36@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=cristian.dumitrescu@intel.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).