From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id B7D007D36; Fri, 25 Aug 2017 12:26:37 +0200 (CEST)
In-Reply-To: <1503488186-90047-2-git-send-email-cristian.dumitrescu@intel.com>
References: <1503488186-90047-2-git-send-email-cristian.dumitrescu@intel.com>
To: test-report@dpdk.org
Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Message-Id: <20170825102637.B7D007D36@dpdk.org>
Date: Fri, 25 Aug 2017 12:26:37 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw27756 [PATCH 1/4] meter: add meter
	configuration profile
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 25 Aug 2017 10:26:38 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/27756

_coding style issues_


WARNING:LONG_LINE: line over 90 characters
#39: FILE: lib/librte_meter/rte_meter.c:63:
+rte_meter_srtcm_profile_config(struct rte_meter_srtcm_profile *p, struct rte_meter_srtcm_params *params)

WARNING:LONG_LINE: line over 90 characters
#60: FILE: lib/librte_meter/rte_meter.c:77:
+	rte_meter_get_tb_params(hz, params->cir, &p->cir_period, &p->cir_bytes_per_period);

WARNING:LONG_LINE: line over 90 characters
#90: FILE: lib/librte_meter/rte_meter.c:98:
+rte_meter_trtcm_profile_config(struct rte_meter_trtcm_profile *p, struct rte_meter_trtcm_params *params)

WARNING:LONG_LINE: line over 90 characters
#115: FILE: lib/librte_meter/rte_meter.c:115:
+	rte_meter_get_tb_params(hz, params->cir, &p->cir_period, &p->cir_bytes_per_period);

WARNING:LONG_LINE: line over 90 characters
#116: FILE: lib/librte_meter/rte_meter.c:116:
+	rte_meter_get_tb_params(hz, params->pir, &p->pir_period, &p->pir_bytes_per_period);

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#170: FILE: lib/librte_meter/rte_meter.h:92:
+/**
+  * Internal data structure storing the trTCM configuration profile. Typically

WARNING:LONG_LINE_COMMENT: line over 90 characters
#317: FILE: lib/librte_meter/rte_meter.h:251:
+	uint64_t cir_period; /* Number of CPU cycles for one update of C and E token buckets */

WARNING:LONG_LINE_COMMENT: line over 90 characters
#318: FILE: lib/librte_meter/rte_meter.h:252:
+	uint64_t cir_bytes_per_period; /* Number of bytes to add to C and E token buckets on each update */

WARNING:LONG_LINE_COMMENT: line over 90 characters
#350: FILE: lib/librte_meter/rte_meter.h:275:
+	uint64_t tc;      /* Number of bytes currently available in the committed (C) token bucket */

WARNING:LONG_LINE_COMMENT: line over 90 characters
#351: FILE: lib/librte_meter/rte_meter.h:276:
+	uint64_t tp;      /* Number of bytes currently available in the peak (P) token bucket */

total: 0 errors, 10 warnings, 457 lines checked