From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id C65097D30; Fri, 25 Aug 2017 12:26:39 +0200 (CEST)
In-Reply-To: <1503489899-26967-1-git-send-email-orika@mellanox.com>
References: <1503489899-26967-1-git-send-email-orika@mellanox.com>
To: test-report@dpdk.org
Cc: Ori k <orika@mellanox.com>
Message-Id: <20170825102639.C65097D30@dpdk.org>
Date: Fri, 25 Aug 2017 12:26:39 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw27759 [PATCH RFC v1] net/mlx4:
	support count flow action
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 25 Aug 2017 10:26:39 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/27759

_coding style issues_


WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#36: FILE: drivers/net/mlx4/mlx4_flow.c:116:
+#ifdef ^IHAVE_VERBS_IBV_EXP_FLOW_SPEC_ACTION_COUNT$

ERROR:SPACING: exactly one space required after that #ifdef
#36: FILE: drivers/net/mlx4/mlx4_flow.c:116:
+#ifdef 	HAVE_VERBS_IBV_EXP_FLOW_SPEC_ACTION_COUNT

ERROR:SPACING: space required before the open parenthesis '('
#54: FILE: drivers/net/mlx4/mlx4_flow.c:750:
+		} else if(actions->type == RTE_FLOW_ACTION_TYPE_COUNT) {

ERROR:SPACING: space required before the open parenthesis '('
#114: FILE: drivers/net/mlx4/mlx4_flow.c:1364:
+	if(res_value < 0) {

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#118: FILE: drivers/net/mlx4/mlx4_flow.c:1368:
+
+	}

ERROR:SWITCH_CASE_INDENT_LEVEL: switch and case should be at the same indent
#140: FILE: drivers/net/mlx4/mlx4_flow.c:1390:
+	switch (type) {
+		case RTE_FLOW_ACTION_TYPE_COUNT:

ERROR:SPACING: space required before the open parenthesis '('
#143: FILE: drivers/net/mlx4/mlx4_flow.c:1393:
+			if(!flow->counter) {

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#151: FILE: drivers/net/mlx4/mlx4_flow.c:1401:
+							(struct rte_flow_query_count*)res,

total: 6 errors, 1 warnings, 1 checks, 153 lines checked