automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Gaetan Rivet <gaetan.rivet@6wind.com>
Subject: [dpdk-test-report] |WARNING| pw27764 [PATCH v2] net/failsafe: safer subdev iterator
Date: Fri, 25 Aug 2017 12:26:43 +0200 (CEST)	[thread overview]
Message-ID: <20170825102643.5A3157CFC@dpdk.org> (raw)
In-Reply-To: <1503493530-22569-1-git-send-email-gaetan.rivet@6wind.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/27764

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 's' - possible side-effects?
#43: FILE: drivers/net/failsafe/failsafe_private.h:223:
+#define FOREACH_SUBDEV_STATE(s, i, dev, state)		\
+	for (s = fs_find_next((dev), 0, state, &i);	\
+	     s != NULL;					\
+	     s = fs_find_next((dev), i + 1, state, &i))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i' - possible side-effects?
#43: FILE: drivers/net/failsafe/failsafe_private.h:223:
+#define FOREACH_SUBDEV_STATE(s, i, dev, state)		\
+	for (s = fs_find_next((dev), 0, state, &i);	\
+	     s != NULL;					\
+	     s = fs_find_next((dev), i + 1, state, &i))

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'i' may be better as '(i)' to avoid precedence issues
#43: FILE: drivers/net/failsafe/failsafe_private.h:223:
+#define FOREACH_SUBDEV_STATE(s, i, dev, state)		\
+	for (s = fs_find_next((dev), 0, state, &i);	\
+	     s != NULL;					\
+	     s = fs_find_next((dev), i + 1, state, &i))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev' - possible side-effects?
#43: FILE: drivers/net/failsafe/failsafe_private.h:223:
+#define FOREACH_SUBDEV_STATE(s, i, dev, state)		\
+	for (s = fs_find_next((dev), 0, state, &i);	\
+	     s != NULL;					\
+	     s = fs_find_next((dev), i + 1, state, &i))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'state' - possible side-effects?
#43: FILE: drivers/net/failsafe/failsafe_private.h:223:
+#define FOREACH_SUBDEV_STATE(s, i, dev, state)		\
+	for (s = fs_find_next((dev), 0, state, &i);	\
+	     s != NULL;					\
+	     s = fs_find_next((dev), i + 1, state, &i))

total: 0 errors, 0 warnings, 5 checks, 48 lines checked

           reply	other threads:[~2017-08-25 10:26 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1503493530-22569-1-git-send-email-gaetan.rivet@6wind.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170825102643.5A3157CFC@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=gaetan.rivet@6wind.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).