* [dpdk-test-report] |WARNING| pw27764 [PATCH v2] net/failsafe: safer subdev iterator
[not found] <1503493530-22569-1-git-send-email-gaetan.rivet@6wind.com>
@ 2017-08-25 10:26 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2017-08-25 10:26 UTC (permalink / raw)
To: test-report; +Cc: Gaetan Rivet
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/27764
_coding style issues_
CHECK:MACRO_ARG_REUSE: Macro argument reuse 's' - possible side-effects?
#43: FILE: drivers/net/failsafe/failsafe_private.h:223:
+#define FOREACH_SUBDEV_STATE(s, i, dev, state) \
+ for (s = fs_find_next((dev), 0, state, &i); \
+ s != NULL; \
+ s = fs_find_next((dev), i + 1, state, &i))
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i' - possible side-effects?
#43: FILE: drivers/net/failsafe/failsafe_private.h:223:
+#define FOREACH_SUBDEV_STATE(s, i, dev, state) \
+ for (s = fs_find_next((dev), 0, state, &i); \
+ s != NULL; \
+ s = fs_find_next((dev), i + 1, state, &i))
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'i' may be better as '(i)' to avoid precedence issues
#43: FILE: drivers/net/failsafe/failsafe_private.h:223:
+#define FOREACH_SUBDEV_STATE(s, i, dev, state) \
+ for (s = fs_find_next((dev), 0, state, &i); \
+ s != NULL; \
+ s = fs_find_next((dev), i + 1, state, &i))
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev' - possible side-effects?
#43: FILE: drivers/net/failsafe/failsafe_private.h:223:
+#define FOREACH_SUBDEV_STATE(s, i, dev, state) \
+ for (s = fs_find_next((dev), 0, state, &i); \
+ s != NULL; \
+ s = fs_find_next((dev), i + 1, state, &i))
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'state' - possible side-effects?
#43: FILE: drivers/net/failsafe/failsafe_private.h:223:
+#define FOREACH_SUBDEV_STATE(s, i, dev, state) \
+ for (s = fs_find_next((dev), 0, state, &i); \
+ s != NULL; \
+ s = fs_find_next((dev), i + 1, state, &i))
total: 0 errors, 0 warnings, 5 checks, 48 lines checked
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2017-08-25 10:26 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1503493530-22569-1-git-send-email-gaetan.rivet@6wind.com>
2017-08-25 10:26 ` [dpdk-test-report] |WARNING| pw27764 [PATCH v2] net/failsafe: safer subdev iterator checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).