From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 5A3157CFC; Fri, 25 Aug 2017 12:26:43 +0200 (CEST)
In-Reply-To: <1503493530-22569-1-git-send-email-gaetan.rivet@6wind.com>
References: <1503493530-22569-1-git-send-email-gaetan.rivet@6wind.com>
To: test-report@dpdk.org
Cc: Gaetan Rivet <gaetan.rivet@6wind.com>
Message-Id: <20170825102643.5A3157CFC@dpdk.org>
Date: Fri, 25 Aug 2017 12:26:43 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw27764 [PATCH v2] net/failsafe: safer
	subdev iterator
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 25 Aug 2017 10:26:43 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/27764

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 's' - possible side-effects?
#43: FILE: drivers/net/failsafe/failsafe_private.h:223:
+#define FOREACH_SUBDEV_STATE(s, i, dev, state)		\
+	for (s = fs_find_next((dev), 0, state, &i);	\
+	     s != NULL;					\
+	     s = fs_find_next((dev), i + 1, state, &i))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i' - possible side-effects?
#43: FILE: drivers/net/failsafe/failsafe_private.h:223:
+#define FOREACH_SUBDEV_STATE(s, i, dev, state)		\
+	for (s = fs_find_next((dev), 0, state, &i);	\
+	     s != NULL;					\
+	     s = fs_find_next((dev), i + 1, state, &i))

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'i' may be better as '(i)' to avoid precedence issues
#43: FILE: drivers/net/failsafe/failsafe_private.h:223:
+#define FOREACH_SUBDEV_STATE(s, i, dev, state)		\
+	for (s = fs_find_next((dev), 0, state, &i);	\
+	     s != NULL;					\
+	     s = fs_find_next((dev), i + 1, state, &i))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev' - possible side-effects?
#43: FILE: drivers/net/failsafe/failsafe_private.h:223:
+#define FOREACH_SUBDEV_STATE(s, i, dev, state)		\
+	for (s = fs_find_next((dev), 0, state, &i);	\
+	     s != NULL;					\
+	     s = fs_find_next((dev), i + 1, state, &i))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'state' - possible side-effects?
#43: FILE: drivers/net/failsafe/failsafe_private.h:223:
+#define FOREACH_SUBDEV_STATE(s, i, dev, state)		\
+	for (s = fs_find_next((dev), 0, state, &i);	\
+	     s != NULL;					\
+	     s = fs_find_next((dev), i + 1, state, &i))

total: 0 errors, 0 warnings, 5 checks, 48 lines checked