automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Ajit Khaparde <ajit.khaparde@broadcom.com>
Subject: [dpdk-test-report] |WARNING| pw27908 [PATCH 7/8] net/bnxt: fix HWRM_*() macros and locking
Date: Fri, 25 Aug 2017 12:30:20 +0200 (CEST)	[thread overview]
Message-ID: <20170825103020.8F1F67D9A@dpdk.org> (raw)
In-Reply-To: <20170824162956.62761-9-ajit.khaparde@broadcom.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/27908

_coding style issues_


WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#88: FILE: drivers/net/bnxt/bnxt_hwrm.c:196:
+#define HWRM_CHECK_RESULT() \
+	do {\
 		if (rc) { \
 			RTE_LOG(ERR, PMD, "%s failed rc:%d
", \
 				__func__, rc); \
+			rte_spinlock_unlock(&bp->hwrm_lock); \
 			return rc; \
 		} \
 		if (resp->error_code) { \

total: 0 errors, 1 warnings, 0 checks, 1259 lines checked

           reply	other threads:[~2017-08-25 10:30 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20170824162956.62761-9-ajit.khaparde@broadcom.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170825103020.8F1F67D9A@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=ajit.khaparde@broadcom.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).