From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 8F1F67D9A; Fri, 25 Aug 2017 12:30:20 +0200 (CEST)
In-Reply-To: <20170824162956.62761-9-ajit.khaparde@broadcom.com>
References: <20170824162956.62761-9-ajit.khaparde@broadcom.com>
To: test-report@dpdk.org
Cc: Ajit Khaparde <ajit.khaparde@broadcom.com>
Message-Id: <20170825103020.8F1F67D9A@dpdk.org>
Date: Fri, 25 Aug 2017 12:30:20 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw27908 [PATCH 7/8] net/bnxt: fix
	HWRM_*() macros and locking
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 25 Aug 2017 10:30:20 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/27908

_coding style issues_


WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#88: FILE: drivers/net/bnxt/bnxt_hwrm.c:196:
+#define HWRM_CHECK_RESULT() \
+	do {\
 		if (rc) { \
 			RTE_LOG(ERR, PMD, "%s failed rc:%d
", \
 				__func__, rc); \
+			rte_spinlock_unlock(&bp->hwrm_lock); \
 			return rc; \
 		} \
 		if (resp->error_code) { \

total: 0 errors, 1 warnings, 0 checks, 1259 lines checked