From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 425397D53; Fri, 25 Aug 2017 12:30:26 +0200 (CEST)
In-Reply-To: <20170824231851.21829-1-dharton@cisco.com>
References: <20170824231851.21829-1-dharton@cisco.com>
To: test-report@dpdk.org
Cc: David Harton <dharton@cisco.com>
Message-Id: <20170825103026.425397D53@dpdk.org>
Date: Fri, 25 Aug 2017 12:30:26 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw27910 [PATCH] ethdev: modifiy
	vlan_offload_set_t to return int
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 25 Aug 2017 10:30:26 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/27910

_coding style issues_


WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct rte_eth_dev *' should also have an identifier name
#505: FILE: drivers/net/mlx5/mlx5.h:286:
+int mlx5_vlan_offload_set(struct rte_eth_dev *, int);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'int' should also have an identifier name
#505: FILE: drivers/net/mlx5/mlx5.h:286:
+int mlx5_vlan_offload_set(struct rte_eth_dev *, int);

CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#628: FILE: drivers/net/virtio/virtio_ethdev.c:1887:
+	if (rxmode->hw_vlan_filter
+	    && !vtpci_with_feature(hw, VIRTIO_NET_F_CTRL_VLAN)) {

ERROR:CODE_INDENT: code indent should use tabs where possible
#715: FILE: lib/librte_ether/rte_ethdev.c:2095:
+        }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#715: FILE: lib/librte_ether/rte_ethdev.c:2095:
+        }$

total: 1 errors, 3 warnings, 533 lines checked