From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Beilei Xing <beilei.xing@intel.com>
Subject: [dpdk-test-report] |WARNING| pw27918 [PATCH 4/7] net/i40e: finish integration FDIR with generic flow API
Date: Fri, 25 Aug 2017 12:30:34 +0200 (CEST) [thread overview]
Message-ID: <20170825103034.70D457D56@dpdk.org> (raw)
In-Reply-To: <1503647430-93905-5-git-send-email-beilei.xing@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/27918
_coding style issues_
CHECK:CAMELCASE: Avoid CamelCase: <ETHER_TYPE_IPv4>
#235: FILE: drivers/net/i40e/i40e_fdir.c:989:
+ *ether_type = rte_cpu_to_be_16(ETHER_TYPE_IPv4);
CHECK:CAMELCASE: Avoid CamelCase: <ETHER_TYPE_IPv6>
#262: FILE: drivers/net/i40e/i40e_fdir.c:1016:
+ *ether_type = rte_cpu_to_be_16(ETHER_TYPE_IPv6);
CHECK:CAMELCASE: Avoid CamelCase: <I40E_FDIR_IPv6_DEFAULT_VTC_FLOW>
#264: FILE: drivers/net/i40e/i40e_fdir.c:1018:
+ rte_cpu_to_be_32(I40E_FDIR_IPv6_DEFAULT_VTC_FLOW |
CHECK:CAMELCASE: Avoid CamelCase: <I40E_FDIR_IPv6_TC_OFFSET>
#266: FILE: drivers/net/i40e/i40e_fdir.c:1020:
+ I40E_FDIR_IPv6_TC_OFFSET));
CHECK:CAMELCASE: Avoid CamelCase: <I40E_FDIR_IPv6_PAYLOAD_LEN>
#268: FILE: drivers/net/i40e/i40e_fdir.c:1022:
+ rte_cpu_to_be_16(I40E_FDIR_IPv6_PAYLOAD_LEN);
CHECK:CAMELCASE: Avoid CamelCase: <I40E_FDIR_IPv6_DEFAULT_HOP_LIMITS>
#274: FILE: drivers/net/i40e/i40e_fdir.c:1028:
+ I40E_FDIR_IPv6_DEFAULT_HOP_LIMITS;
CHECK:BRACES: braces {} should be used on all arms of this statement
#509: FILE: drivers/net/i40e/i40e_fdir.c:1384:
+ if (hw->mac.type == I40E_MAC_X722) {
[...]
+ } else
[...]
CHECK:BRACES: Unbalanced braces around else statement
#515: FILE: drivers/net/i40e/i40e_fdir.c:1390:
+ } else
CHECK:BRACES: braces {} should be used on all arms of this statement
#660: FILE: drivers/net/i40e/i40e_fdir.c:1690:
+ if (fdir_action->behavior == I40E_FDIR_REJECT)
[...]
+ else if (fdir_action->behavior == I40E_FDIR_ACCEPT)
[...]
+ else if (fdir_action->behavior == I40E_FDIR_PASSTHRU)
[...]
+ else {
[...]
CHECK:BRACES: Unbalanced braces around else statement
#666: FILE: drivers/net/i40e/i40e_fdir.c:1696:
+ else {
total: 0 errors, 0 warnings, 10 checks, 897 lines checked
parent reply other threads:[~2017-08-25 10:30 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1503647430-93905-5-git-send-email-beilei.xing@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170825103034.70D457D56@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=beilei.xing@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).