From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id A12B68CF0; Fri, 25 Aug 2017 17:02:17 +0200 (CEST)
In-Reply-To: <1503673046-30651-5-git-send-email-radu.nicolau@intel.com>
References: <1503673046-30651-5-git-send-email-radu.nicolau@intel.com>
To: test-report@dpdk.org
Cc: Radu Nicolau <radu.nicolau@intel.com>
Message-Id: <20170825150217.A12B68CF0@dpdk.org>
Date: Fri, 25 Aug 2017 17:02:17 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw27989 [PATCH RFC 4/5] ixgbe: enable
	inline ipsec
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 25 Aug 2017 15:02:17 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/27989

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse '__reg' - possible side-effects?
#160: FILE: drivers/net/ixgbe/ixgbe_ipsec.c:47:
+#define IXGBE_WAIT_RW(__reg, __rw)			\
+{							\
+	IXGBE_WRITE_REG(hw, (__reg), reg);		\
+	while ((IXGBE_READ_REG(hw, (__reg))) & (__rw))	\
+	;						\
+}

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'a' - possible side-effects?
#171: FILE: drivers/net/ixgbe/ixgbe_ipsec.c:58:
+#define CMP_IP(a, b)	\
+		((a).ipv6[0] == (b).ipv6[0] && (a).ipv6[1] == (b).ipv6[1] && \
+		(a).ipv6[2] == (b).ipv6[2] && (a).ipv6[3] == (b).ipv6[3])

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'b' - possible side-effects?
#171: FILE: drivers/net/ixgbe/ixgbe_ipsec.c:58:
+#define CMP_IP(a, b)	\
+		((a).ipv6[0] == (b).ipv6[0] && (a).ipv6[1] == (b).ipv6[1] && \
+		(a).ipv6[2] == (b).ipv6[2] && (a).ipv6[3] == (b).ipv6[3])

CHECK:CAMELCASE: Avoid CamelCase: <IPv6>
#410: FILE: drivers/net/ixgbe/ixgbe_ipsec.c:297:
+		if (sess->dst_ip.type == IPv6)

CHECK:CAMELCASE: Avoid CamelCase: <IPv4>
#417: FILE: drivers/net/ixgbe/ixgbe_ipsec.c:304:
+		if (priv->rx_ip_table[ip_index].ip.type == IPv4) {

total: 0 errors, 0 warnings, 5 checks, 943 lines checked