automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Yongseok Koh <yskoh@mellanox.com>
Subject: [dpdk-test-report] |WARNING| pw28015 [PATCH RFC 1/1] net/mlx5: add vectorized Rx/Tx burst for ARM
Date: Fri, 25 Aug 2017 20:41:31 +0200 (CEST)	[thread overview]
Message-ID: <20170825184131.C9E357D66@dpdk.org> (raw)
In-Reply-To: <20170825184023.31692-2-yskoh@mellanox.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/28015

_coding style issues_


CHECK:REDUNDANT_CODE: if this code is redundant consider removing it
#73: FILE: drivers/net/mlx5/mlx5_prm.h:227:
+#if 0

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#75: FILE: drivers/net/mlx5/mlx5_prm.h:229:
+       uint16_t hdr_type_etc;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#76: FILE: drivers/net/mlx5/mlx5_prm.h:230:
+       uint8_t pkt_info;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#77: FILE: drivers/net/mlx5/mlx5_prm.h:231:
+       uint8_t sop_drop_qpn; /* flow_tag */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#78: FILE: drivers/net/mlx5/mlx5_prm.h:232:
+       uint16_t byte_cnt;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#79: FILE: drivers/net/mlx5/mlx5_prm.h:233:
+       uint16_t vlan_info;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#80: FILE: drivers/net/mlx5/mlx5_prm.h:234:
+       uint32_t rx_hash_res;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#81: FILE: drivers/net/mlx5/mlx5_prm.h:235:
+       uint8_t timestamp;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#82: FILE: drivers/net/mlx5/mlx5_prm.h:236:
+       uint8_t wqe_counter;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#83: FILE: drivers/net/mlx5/mlx5_prm.h:237:
+       uint8_t rsvd4;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#84: FILE: drivers/net/mlx5/mlx5_prm.h:238:
+       uint8_t op_own;$

CHECK:REDUNDANT_CODE: if this code is redundant consider removing it
#322: FILE: drivers/net/mlx5/mlx5_rxtx_vec_neon.c:114:
+#if 0

CHECK:REDUNDANT_CODE: if this code is redundant consider removing it
#678: FILE: drivers/net/mlx5/mlx5_rxtx_vec_neon.c:470:
+#if 0

ERROR:SPACING: spaces required around that ':' (ctx:ExV)
#928: FILE: drivers/net/mlx5/mlx5_rxtx_vec_neon.c:720:
+		:[byte_cnt]"=&w"(byte_cnt)
 		^

ERROR:SPACING: spaces required around that ':' (ctx:ExV)
#929: FILE: drivers/net/mlx5/mlx5_rxtx_vec_neon.c:721:
+		:[mcq]"r"(p), [rxdf]"w"(rxdf), [rearm]"w"(rearm),
 		^

ERROR:SPACING: spaces required around that ':' (ctx:ExV)
#934: FILE: drivers/net/mlx5/mlx5_rxtx_vec_neon.c:726:
+		:"memory", "v16", "v17", "v18", "v19");
 		^

CHECK:REDUNDANT_CODE: if this code is redundant consider removing it
#970: FILE: drivers/net/mlx5/mlx5_rxtx_vec_neon.c:762:
+#if 0

ERROR:SPACING: spaces required around that ':' (ctx:ExV)
#1417: FILE: drivers/net/mlx5/mlx5_rxtx_vec_neon.c:1209:
+		:[op_own]"=&w"(op_own), [byte_cnt]"=&w"(byte_cnt)
 		^

ERROR:SPACING: spaces required around that ':' (ctx:ExV)
#1418: FILE: drivers/net/mlx5/mlx5_rxtx_vec_neon.c:1210:
+		:[p3]"r"(p3 + 48), [p2]"r"(p2 + 48),
 		^

ERROR:SPACING: spaces required around that ':' (ctx:ExV)
#1425: FILE: drivers/net/mlx5/mlx5_rxtx_vec_neon.c:1217:
+		:"memory",
 		^

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#1469: FILE: drivers/net/mlx5/mlx5_rxtx_vec_neon.c:1261:
+		/* TODO:
+		rxq_cq_to_ptype_oflags_v(rxq, cqes, opcode, &pkts[pos]); */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#1469: FILE: drivers/net/mlx5/mlx5_rxtx_vec_neon.c:1261:
+		rxq_cq_to_ptype_oflags_v(rxq, cqes, opcode, &pkts[pos]); */

total: 6 errors, 12 warnings, 4 checks, 1608 lines checked

           reply	other threads:[~2017-08-25 18:41 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20170825184023.31692-2-yskoh@mellanox.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170825184131.C9E357D66@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=test-report@dpdk.org \
    --cc=yskoh@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).