From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Subject: [dpdk-test-report] |WARNING| pw28022 [PATCH 2/3] ethdev: add new rte_mtr API for traffic metering and policing
Date: Sat, 26 Aug 2017 02:06:57 +0200 (CEST) [thread overview]
Message-ID: <20170826000657.DFF5B7D6E@dpdk.org> (raw)
In-Reply-To: <1503705973-80742-3-git-send-email-cristian.dumitrescu@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/28022
_coding style issues_
WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#181: FILE: lib/librte_ether/rte_mtr.c:61:
+ ENOSYS,
WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#184: FILE: lib/librte_ether/rte_mtr.c:64:
+ rte_strerror(ENOSYS));
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#191: FILE: lib/librte_ether/rte_mtr.c:71:
+#define RTE_MTR_FUNC(port_id, func) \
+({ \
+ const struct rte_mtr_ops *ops = \
+ rte_mtr_ops_get(port_id, error); \
+ if (ops == NULL) \
+ return -rte_errno; \
+ \
+ if (ops->func == NULL) \
+ return -rte_mtr_error_set(error, \
+ ENOSYS, \
+ RTE_MTR_ERROR_TYPE_UNSPECIFIED, \
+ NULL, \
+ rte_strerror(ENOSYS)); \
+ \
+ ops->func; \
+})
WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#200: FILE: lib/librte_ether/rte_mtr.c:80:
+ ENOSYS, \
WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#203: FILE: lib/librte_ether/rte_mtr.c:83:
+ rte_strerror(ENOSYS)); \
total: 0 errors, 5 warnings, 898 lines checked
parent reply other threads:[~2017-08-26 0:06 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1503705973-80742-3-git-send-email-cristian.dumitrescu@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170826000657.DFF5B7D6E@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=cristian.dumitrescu@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).