automatic DPDK test reports
 help / color / mirror / Atom feed
* [dpdk-test-report] |WARNING| pw28022 [PATCH 2/3] ethdev: add new rte_mtr API for traffic metering and policing
       [not found] <1503705973-80742-3-git-send-email-cristian.dumitrescu@intel.com>
@ 2017-08-26  0:06 ` checkpatch
  0 siblings, 0 replies; only message in thread
From: checkpatch @ 2017-08-26  0:06 UTC (permalink / raw)
  To: test-report; +Cc: Cristian Dumitrescu

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/28022

_coding style issues_


WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#181: FILE: lib/librte_ether/rte_mtr.c:61:
+			ENOSYS,

WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#184: FILE: lib/librte_ether/rte_mtr.c:64:
+			rte_strerror(ENOSYS));

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#191: FILE: lib/librte_ether/rte_mtr.c:71:
+#define RTE_MTR_FUNC(port_id, func)			\
+({							\
+	const struct rte_mtr_ops *ops =			\
+		rte_mtr_ops_get(port_id, error);		\
+	if (ops == NULL)					\
+		return -rte_errno;			\
+							\
+	if (ops->func == NULL)				\
+		return -rte_mtr_error_set(error,		\
+			ENOSYS,				\
+			RTE_MTR_ERROR_TYPE_UNSPECIFIED,	\
+			NULL,				\
+			rte_strerror(ENOSYS));		\
+							\
+	ops->func;					\
+})

WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#200: FILE: lib/librte_ether/rte_mtr.c:80:
+			ENOSYS,				\

WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#203: FILE: lib/librte_ether/rte_mtr.c:83:
+			rte_strerror(ENOSYS));		\

total: 0 errors, 5 warnings, 898 lines checked

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2017-08-26  0:06 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <1503705973-80742-3-git-send-email-cristian.dumitrescu@intel.com>
2017-08-26  0:06 ` [dpdk-test-report] |WARNING| pw28022 [PATCH 2/3] ethdev: add new rte_mtr API for traffic metering and policing checkpatch

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).