From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id DFF5B7D6E; Sat, 26 Aug 2017 02:06:57 +0200 (CEST)
In-Reply-To: <1503705973-80742-3-git-send-email-cristian.dumitrescu@intel.com>
References: <1503705973-80742-3-git-send-email-cristian.dumitrescu@intel.com>
To: test-report@dpdk.org
Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Message-Id: <20170826000657.DFF5B7D6E@dpdk.org>
Date: Sat, 26 Aug 2017 02:06:57 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw28022 [PATCH 2/3] ethdev: add new
	rte_mtr API for traffic metering and policing
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sat, 26 Aug 2017 00:06:58 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/28022

_coding style issues_


WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#181: FILE: lib/librte_ether/rte_mtr.c:61:
+			ENOSYS,

WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#184: FILE: lib/librte_ether/rte_mtr.c:64:
+			rte_strerror(ENOSYS));

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#191: FILE: lib/librte_ether/rte_mtr.c:71:
+#define RTE_MTR_FUNC(port_id, func)			\
+({							\
+	const struct rte_mtr_ops *ops =			\
+		rte_mtr_ops_get(port_id, error);		\
+	if (ops == NULL)					\
+		return -rte_errno;			\
+							\
+	if (ops->func == NULL)				\
+		return -rte_mtr_error_set(error,		\
+			ENOSYS,				\
+			RTE_MTR_ERROR_TYPE_UNSPECIFIED,	\
+			NULL,				\
+			rte_strerror(ENOSYS));		\
+							\
+	ops->func;					\
+})

WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#200: FILE: lib/librte_ether/rte_mtr.c:80:
+			ENOSYS,				\

WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#203: FILE: lib/librte_ether/rte_mtr.c:83:
+			rte_strerror(ENOSYS));		\

total: 0 errors, 5 warnings, 898 lines checked