automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: [dpdk-test-report] |WARNING| pw28032 [PATCH 4/4] net/sfc/base: insert filters for encapsulated packets
Date: Mon, 28 Aug 2017 15:26:03 +0200 (CEST)	[thread overview]
Message-ID: <20170828132603.2874A325A@dpdk.org> (raw)
In-Reply-To: <1503926727-2269-5-git-send-email-arybchenko@solarflare.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/28032

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#71: FILE: drivers/net/sfc/base/ef10_filter.c:1263:
+static	__checkReturn	efx_rc_t

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 32)
#108: FILE: drivers/net/sfc/base/ef10_filter.c:1300:
+		if ((mulcst == B_FALSE) &&
[...]
+				continue;

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#134: FILE: drivers/net/sfc/base/ef10_filter.c:1326:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#141: FILE: drivers/net/sfc/base/ef10_filter.c:1333:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#152: FILE: drivers/net/sfc/base/ef10_filter.c:1432:
+			(void) ef10_filter_delete_internal(enp,

CHECK:SPACING: No space is necessary after a cast
#177: FILE: drivers/net/sfc/base/ef10_filter.c:1577:
+		(void) ef10_filter_insert_encap_filters(enp,

total: 2 errors, 1 warnings, 3 checks, 165 lines checked

           reply	other threads:[~2017-08-28 13:26 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1503926727-2269-5-git-send-email-arybchenko@solarflare.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170828132603.2874A325A@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=arybchenko@solarflare.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).