From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 2874A325A; Mon, 28 Aug 2017 15:26:03 +0200 (CEST)
In-Reply-To: <1503926727-2269-5-git-send-email-arybchenko@solarflare.com>
References: <1503926727-2269-5-git-send-email-arybchenko@solarflare.com>
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Message-Id: <20170828132603.2874A325A@dpdk.org>
Date: Mon, 28 Aug 2017 15:26:03 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw28032 [PATCH 4/4] net/sfc/base:
	insert filters for encapsulated packets
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 28 Aug 2017 13:26:03 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/28032

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#71: FILE: drivers/net/sfc/base/ef10_filter.c:1263:
+static	__checkReturn	efx_rc_t

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 32)
#108: FILE: drivers/net/sfc/base/ef10_filter.c:1300:
+		if ((mulcst == B_FALSE) &&
[...]
+				continue;

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#134: FILE: drivers/net/sfc/base/ef10_filter.c:1326:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#141: FILE: drivers/net/sfc/base/ef10_filter.c:1333:
+	return (rc);

CHECK:SPACING: No space is necessary after a cast
#152: FILE: drivers/net/sfc/base/ef10_filter.c:1432:
+			(void) ef10_filter_delete_internal(enp,

CHECK:SPACING: No space is necessary after a cast
#177: FILE: drivers/net/sfc/base/ef10_filter.c:1577:
+		(void) ef10_filter_insert_encap_filters(enp,

total: 2 errors, 1 warnings, 3 checks, 165 lines checked