From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Nirmoy Das <ndas@suse.de>
Subject: [dpdk-test-report] |WARNING| pw28062 [PATCH v2] kni: fix build on SLE12 SP3
Date: Tue, 29 Aug 2017 17:06:29 +0200 (CEST) [thread overview]
Message-ID: <20170829150629.80E9D2C2A@dpdk.org> (raw)
In-Reply-To: <20170829150613.10597-1-ndas@suse.de>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/28062
_coding style issues_
WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#38: FILE: lib/librte_eal/linuxapp/kni/compat.h:16:
+#if (LINUX_VERSION_CODE >= KERNEL_VERSION(4, 4, 57))
WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#41: FILE: lib/librte_eal/linuxapp/kni/compat.h:19:
+#elif (LINUX_VERSION_CODE >= KERNEL_VERSION(3, 12, 28))
WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#44: FILE: lib/librte_eal/linuxapp/kni/compat.h:22:
+#elif ((LINUX_VERSION_CODE >= KERNEL_VERSION(3, 0, 61)) && \
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#45: FILE: lib/librte_eal/linuxapp/kni/compat.h:23:
+ (LINUX_VERSION_CODE < KERNEL_VERSION(3, 1, 0)))$
WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#45: FILE: lib/librte_eal/linuxapp/kni/compat.h:23:
+ (LINUX_VERSION_CODE < KERNEL_VERSION(3, 1, 0)))
WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#48: FILE: lib/librte_eal/linuxapp/kni/compat.h:26:
+#elif (LINUX_VERSION_CODE == KERNEL_VERSION(2, 6, 32))
WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#51: FILE: lib/librte_eal/linuxapp/kni/compat.h:29:
+#elif (LINUX_VERSION_CODE == KERNEL_VERSION(2, 6, 27))
WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#69: FILE: lib/librte_eal/linuxapp/kni/compat.h:86:
+ RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 4)) || \
WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#71: FILE: lib/librte_eal/linuxapp/kni/compat.h:88:
+ SLE_VERSION_CODE == SLE_VERSION(12, 3, 0))
total: 0 errors, 9 warnings, 44 lines checked
parent reply other threads:[~2017-08-29 15:06 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20170829150613.10597-1-ndas@suse.de>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170829150629.80E9D2C2A@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=ndas@suse.de \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).