From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 80E9D2C2A; Tue, 29 Aug 2017 17:06:29 +0200 (CEST)
In-Reply-To: <20170829150613.10597-1-ndas@suse.de>
References: <20170829150613.10597-1-ndas@suse.de>
To: test-report@dpdk.org
Cc: Nirmoy Das <ndas@suse.de>
Message-Id: <20170829150629.80E9D2C2A@dpdk.org>
Date: Tue, 29 Aug 2017 17:06:29 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw28062 [PATCH v2] kni: fix build on
	SLE12 SP3
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Aug 2017 15:06:29 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/28062

_coding style issues_


WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#38: FILE: lib/librte_eal/linuxapp/kni/compat.h:16:
+#if (LINUX_VERSION_CODE >= KERNEL_VERSION(4, 4, 57))

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#41: FILE: lib/librte_eal/linuxapp/kni/compat.h:19:
+#elif (LINUX_VERSION_CODE >= KERNEL_VERSION(3, 12, 28))

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#44: FILE: lib/librte_eal/linuxapp/kni/compat.h:22:
+#elif ((LINUX_VERSION_CODE >= KERNEL_VERSION(3, 0, 61)) && \

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#45: FILE: lib/librte_eal/linuxapp/kni/compat.h:23:
+       (LINUX_VERSION_CODE < KERNEL_VERSION(3, 1, 0)))$

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#45: FILE: lib/librte_eal/linuxapp/kni/compat.h:23:
+       (LINUX_VERSION_CODE < KERNEL_VERSION(3, 1, 0)))

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#48: FILE: lib/librte_eal/linuxapp/kni/compat.h:26:
+#elif (LINUX_VERSION_CODE == KERNEL_VERSION(2, 6, 32))

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#51: FILE: lib/librte_eal/linuxapp/kni/compat.h:29:
+#elif (LINUX_VERSION_CODE == KERNEL_VERSION(2, 6, 27))

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#69: FILE: lib/librte_eal/linuxapp/kni/compat.h:86:
+	 RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 4)) || \

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#71: FILE: lib/librte_eal/linuxapp/kni/compat.h:88:
+	  SLE_VERSION_CODE == SLE_VERSION(12, 3, 0))

total: 0 errors, 9 warnings, 44 lines checked