From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Kirill Rybalchenko <kirill.rybalchenko@intel.com>
Subject: [dpdk-test-report] |WARNING| pw28073 [PATCH 2/2] app/testpmd: get information about protocols defined in ddp
Date: Wed, 30 Aug 2017 08:51:11 +0200 (CEST) [thread overview]
Message-ID: <20170830065111.0415B3251@dpdk.org> (raw)
In-Reply-To: <1504075836-102681-3-git-send-email-kirill.rybalchenko@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/28073
_coding style issues_
WARNING:LONG_LINE: line over 90 characters
#68: FILE: app/test-pmd/cmdline.c:13527:
+ printf(" %2u: %s
", proto[i].proto_id, proto[i].name);
WARNING:LONG_LINE: line over 90 characters
#76: FILE: app/test-pmd/cmdline.c:13535:
+ malloc(pctype_num * sizeof(struct rte_pmd_i40e_ptype_info));
WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#83: FILE: app/test-pmd/cmdline.c:13542:
+ for (i = 0; i < pctype_num; i++) {
WARNING:LONG_LINE: line over 90 characters
#84: FILE: app/test-pmd/cmdline.c:13543:
+ printf(" %2u:", pctype[i].ptype_id);
WARNING:LONG_LINE: line over 90 characters
#85: FILE: app/test-pmd/cmdline.c:13544:
+ for (j = 0; j < RTE_PMD_I40E_PROTO_NUM; j++) {
WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#85: FILE: app/test-pmd/cmdline.c:13544:
+ for (j = 0; j < RTE_PMD_I40E_PROTO_NUM; j++) {
WARNING:LONG_LINE: line over 90 characters
#86: FILE: app/test-pmd/cmdline.c:13545:
+ proto_id = pctype[i].protocols[j];
WARNING:LONG_LINE: line over 90 characters
#87: FILE: app/test-pmd/cmdline.c:13546:
+ if (proto_id != RTE_PMD_I40E_PROTO_UNUSED) {
WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#87: FILE: app/test-pmd/cmdline.c:13546:
+ if (proto_id != RTE_PMD_I40E_PROTO_UNUSED) {
WARNING:LONG_LINE: line over 90 characters
#88: FILE: app/test-pmd/cmdline.c:13547:
+ for (n = 0; n < proto_num; n++) {
WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#88: FILE: app/test-pmd/cmdline.c:13547:
+ for (n = 0; n < proto_num; n++) {
WARNING:LONG_LINE: line over 90 characters
#89: FILE: app/test-pmd/cmdline.c:13548:
+ if (proto[n].proto_id == proto_id) {
WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#89: FILE: app/test-pmd/cmdline.c:13548:
+ if (proto[n].proto_id == proto_id) {
WARNING:LONG_LINE: line over 90 characters
#90: FILE: app/test-pmd/cmdline.c:13549:
+ printf(" %s", proto[n].name);
WARNING:LONG_LINE: line over 90 characters
#91: FILE: app/test-pmd/cmdline.c:13550:
+ break;
WARNING:LONG_LINE: line over 90 characters
#108: FILE: app/test-pmd/cmdline.c:13567:
+ malloc(ptype_num * sizeof(struct rte_pmd_i40e_ptype_info));
WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#115: FILE: app/test-pmd/cmdline.c:13574:
+ for (i = 0; i < ptype_num; i++) {
WARNING:LONG_LINE: line over 90 characters
#116: FILE: app/test-pmd/cmdline.c:13575:
+ printf(" %2u:", ptype[i].ptype_id);
WARNING:LONG_LINE: line over 90 characters
#117: FILE: app/test-pmd/cmdline.c:13576:
+ for (j = 0; j < RTE_PMD_I40E_PROTO_NUM; j++) {
WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#117: FILE: app/test-pmd/cmdline.c:13576:
+ for (j = 0; j < RTE_PMD_I40E_PROTO_NUM; j++) {
WARNING:LONG_LINE: line over 90 characters
#118: FILE: app/test-pmd/cmdline.c:13577:
+ proto_id = ptype[i].protocols[j];
WARNING:LONG_LINE: line over 90 characters
#119: FILE: app/test-pmd/cmdline.c:13578:
+ if (proto_id != RTE_PMD_I40E_PROTO_UNUSED) {
WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#119: FILE: app/test-pmd/cmdline.c:13578:
+ if (proto_id != RTE_PMD_I40E_PROTO_UNUSED) {
WARNING:LONG_LINE: line over 90 characters
#120: FILE: app/test-pmd/cmdline.c:13579:
+ for (n = 0; n < proto_num; n++) {
WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#120: FILE: app/test-pmd/cmdline.c:13579:
+ for (n = 0; n < proto_num; n++) {
WARNING:LONG_LINE: line over 90 characters
#121: FILE: app/test-pmd/cmdline.c:13580:
+ if (proto[n].proto_id == proto_id) {
WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#121: FILE: app/test-pmd/cmdline.c:13580:
+ if (proto[n].proto_id == proto_id) {
WARNING:LONG_LINE: line over 90 characters
#122: FILE: app/test-pmd/cmdline.c:13581:
+ printf(" %s", proto[n].name);
WARNING:LONG_LINE: line over 90 characters
#123: FILE: app/test-pmd/cmdline.c:13582:
+ break;
total: 0 errors, 29 warnings, 111 lines checked
parent reply other threads:[~2017-08-30 6:51 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1504075836-102681-3-git-send-email-kirill.rybalchenko@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170830065111.0415B3251@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=kirill.rybalchenko@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).