automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: [dpdk-test-report] |WARNING| pw28095 [PATCH 06/11] net/sfc/base: add API to allocate and free RSS contexts
Date: Wed, 30 Aug 2017 20:18:50 +0200 (CEST)	[thread overview]
Message-ID: <20170830181850.C2D433230@dpdk.org> (raw)
In-Reply-To: <1504117061-17906-7-git-send-email-arybchenko@solarflare.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/28095

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#43: FILE: drivers/net/sfc/base/ef10_impl.h:907:
+extern	__checkReturn	efx_rc_t

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#72: FILE: drivers/net/sfc/base/ef10_rx.c:506:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#76: FILE: drivers/net/sfc/base/ef10_rx.c:510:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#92: FILE: drivers/net/sfc/base/ef10_rx.c:526:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#96: FILE: drivers/net/sfc/base/ef10_rx.c:530:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#189: FILE: drivers/net/sfc/base/efx_rx.c:387:
+	if ((rc = erxop->erxo_scale_context_alloc(enp, type,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#194: FILE: drivers/net/sfc/base/efx_rx.c:392:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#200: FILE: drivers/net/sfc/base/efx_rx.c:398:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#220: FILE: drivers/net/sfc/base/efx_rx.c:418:
+	if ((rc = erxop->erxo_scale_context_free(enp, rss_context)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#223: FILE: drivers/net/sfc/base/efx_rx.c:421:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#229: FILE: drivers/net/sfc/base/efx_rx.c:427:
+	return (rc);

total: 10 errors, 0 warnings, 1 checks, 181 lines checked

           reply	other threads:[~2017-08-30 18:18 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1504117061-17906-7-git-send-email-arybchenko@solarflare.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170830181850.C2D433230@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=arybchenko@solarflare.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).