From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id C2D433230; Wed, 30 Aug 2017 20:18:50 +0200 (CEST)
In-Reply-To: <1504117061-17906-7-git-send-email-arybchenko@solarflare.com>
References: <1504117061-17906-7-git-send-email-arybchenko@solarflare.com>
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Message-Id: <20170830181850.C2D433230@dpdk.org>
Date: Wed, 30 Aug 2017 20:18:50 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw28095 [PATCH 06/11] net/sfc/base:
	add API to allocate and free RSS contexts
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Aug 2017 18:18:51 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/28095

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#43: FILE: drivers/net/sfc/base/ef10_impl.h:907:
+extern	__checkReturn	efx_rc_t

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#72: FILE: drivers/net/sfc/base/ef10_rx.c:506:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#76: FILE: drivers/net/sfc/base/ef10_rx.c:510:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#92: FILE: drivers/net/sfc/base/ef10_rx.c:526:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#96: FILE: drivers/net/sfc/base/ef10_rx.c:530:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#189: FILE: drivers/net/sfc/base/efx_rx.c:387:
+	if ((rc = erxop->erxo_scale_context_alloc(enp, type,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#194: FILE: drivers/net/sfc/base/efx_rx.c:392:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#200: FILE: drivers/net/sfc/base/efx_rx.c:398:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#220: FILE: drivers/net/sfc/base/efx_rx.c:418:
+	if ((rc = erxop->erxo_scale_context_free(enp, rss_context)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#223: FILE: drivers/net/sfc/base/efx_rx.c:421:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#229: FILE: drivers/net/sfc/base/efx_rx.c:427:
+	return (rc);

total: 10 errors, 0 warnings, 1 checks, 181 lines checked