From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 1017) id EC8DF9101; Thu, 31 Aug 2017 16:56:18 +0200 (CEST) In-Reply-To: <1504191287-11349-5-git-send-email-bernard.iremonger@intel.com> References: <1504191287-11349-5-git-send-email-bernard.iremonger@intel.com> To: test-report@dpdk.org Cc: Bernard Iremonger Message-Id: <20170831145618.EC8DF9101@dpdk.org> Date: Thu, 31 Aug 2017 16:56:18 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw28164 [PATCH v3 4/5] examples/flow_classify: flow classify sample application X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Aug 2017 14:56:19 -0000 Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/28164 _coding style issues_ WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #181: FILE: examples/flow_classify/flow_classify.c:73: +#define GET_CB_FIELD(in, fd, base, lim, dlm) do { \ + unsigned long val; \ + char *end; \ + errno = 0; \ + val = strtoul((in), &end, (base)); \ + if (errno != 0 || end[0] != (dlm) || val > (lim)) \ + return -EINVAL; \ + (fd) = (typeof(fd))val; \ + (in) = end + 1; \ +} while (0) total: 0 errors, 1 warnings, 950 lines checked