automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Kirill Rybalchenko <kirill.rybalchenko@intel.com>
Subject: [dpdk-test-report] |WARNING| pw28295 [PATCH v2 2/2] app/testpmd: get information about protocols defined in ddp
Date: Fri,  1 Sep 2017 18:01:44 +0200 (CEST)	[thread overview]
Message-ID: <20170901160144.B662758CB@dpdk.org> (raw)
In-Reply-To: <1504281685-54502-3-git-send-email-kirill.rybalchenko@intel.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/28295

_coding style issues_


WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#86: FILE: app/test-pmd/cmdline.c:13545:
+						for (i = 0; i < pctype_num; i++) {

WARNING:LONG_LINE: line over 90 characters
#87: FILE: app/test-pmd/cmdline.c:13546:
+							printf("  %2u:", pctype[i].ptype_id);

WARNING:LONG_LINE: line over 90 characters
#88: FILE: app/test-pmd/cmdline.c:13547:
+							for (j = 0; j < RTE_PMD_I40E_PROTO_NUM; j++) {

WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#88: FILE: app/test-pmd/cmdline.c:13547:
+							for (j = 0; j < RTE_PMD_I40E_PROTO_NUM; j++) {

WARNING:LONG_LINE: line over 90 characters
#89: FILE: app/test-pmd/cmdline.c:13548:
+								proto_id = pctype[i].protocols[j];

WARNING:LONG_LINE: line over 90 characters
#90: FILE: app/test-pmd/cmdline.c:13549:
+								if (proto_id != RTE_PMD_I40E_PROTO_UNUSED) {

WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#90: FILE: app/test-pmd/cmdline.c:13549:
+								if (proto_id != RTE_PMD_I40E_PROTO_UNUSED) {

WARNING:LONG_LINE: line over 90 characters
#91: FILE: app/test-pmd/cmdline.c:13550:
+									for (n = 0; n < proto_num; n++) {

WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#91: FILE: app/test-pmd/cmdline.c:13550:
+									for (n = 0; n < proto_num; n++) {

WARNING:LONG_LINE: line over 90 characters
#92: FILE: app/test-pmd/cmdline.c:13551:
+										if (proto[n].proto_id == proto_id) {

WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#92: FILE: app/test-pmd/cmdline.c:13551:
+										if (proto[n].proto_id == proto_id) {

WARNING:LONG_LINE: line over 90 characters
#93: FILE: app/test-pmd/cmdline.c:13552:
+											printf(" %s", proto[n].name);

WARNING:LONG_LINE: line over 90 characters
#94: FILE: app/test-pmd/cmdline.c:13553:
+											break;

WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#119: FILE: app/test-pmd/cmdline.c:13578:
+						for (i = 0; i < ptype_num; i++) {

WARNING:LONG_LINE: line over 90 characters
#120: FILE: app/test-pmd/cmdline.c:13579:
+							printf("  %2u:", ptype[i].ptype_id);

WARNING:LONG_LINE: line over 90 characters
#121: FILE: app/test-pmd/cmdline.c:13580:
+							for (j = 0; j < RTE_PMD_I40E_PROTO_NUM; j++) {

WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#121: FILE: app/test-pmd/cmdline.c:13580:
+							for (j = 0; j < RTE_PMD_I40E_PROTO_NUM; j++) {

WARNING:LONG_LINE: line over 90 characters
#122: FILE: app/test-pmd/cmdline.c:13581:
+								proto_id = ptype[i].protocols[j];

WARNING:LONG_LINE: line over 90 characters
#123: FILE: app/test-pmd/cmdline.c:13582:
+								if (proto_id != RTE_PMD_I40E_PROTO_UNUSED) {

WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#123: FILE: app/test-pmd/cmdline.c:13582:
+								if (proto_id != RTE_PMD_I40E_PROTO_UNUSED) {

WARNING:LONG_LINE: line over 90 characters
#124: FILE: app/test-pmd/cmdline.c:13583:
+									for (n = 0; n < proto_num; n++) {

WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#124: FILE: app/test-pmd/cmdline.c:13583:
+									for (n = 0; n < proto_num; n++) {

WARNING:LONG_LINE: line over 90 characters
#125: FILE: app/test-pmd/cmdline.c:13584:
+										if (proto[n].proto_id == proto_id) {

WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#125: FILE: app/test-pmd/cmdline.c:13584:
+										if (proto[n].proto_id == proto_id) {

WARNING:LONG_LINE: line over 90 characters
#126: FILE: app/test-pmd/cmdline.c:13585:
+											printf(" %s", proto[n].name);

WARNING:LONG_LINE: line over 90 characters
#127: FILE: app/test-pmd/cmdline.c:13586:
+											break;

total: 0 errors, 26 warnings, 115 lines checked

           reply	other threads:[~2017-09-01 16:01 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1504281685-54502-3-git-send-email-kirill.rybalchenko@intel.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170901160144.B662758CB@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=kirill.rybalchenko@intel.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).