From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id E601E7CC0; Sun,  3 Sep 2017 17:50:17 +0200 (CEST)
In-Reply-To: <1504453785-15735-2-git-send-email-jia.guo@intel.com>
References: <1504453785-15735-2-git-send-email-jia.guo@intel.com>
To: test-report@dpdk.org
Cc: Guo Jia <jia.guo@intel.com>
Message-Id: <20170903155017.E601E7CC0@dpdk.org>
Date: Sun,  3 Sep 2017 17:50:17 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw28310 [PATCH v4 1/2] eal: add uevent
	monitor for hot plug
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 03 Sep 2017 15:50:18 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/28310

_coding style issues_


WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#224: FILE: lib/librte_eal/common/eal_common_dev.c:385:
+		return -1;
+	} else

WARNING:LONG_LINE: line over 90 characters
#699: FILE: lib/librte_eal/linuxapp/eal/eal_pci_uio.c:258:
+			map_address = pci_map_private_resource(dev->mem_resource[i].addr, 0,

WARNING:LONG_LINE_COMMENT: line over 90 characters
#724: FILE: lib/librte_eal/linuxapp/eal/eal_pci_uio.c:283:
+				/*remap the resource to be fake before removal processing */

WARNING:LONG_LINE: line over 90 characters
#727: FILE: lib/librte_eal/linuxapp/eal/eal_pci_uio.c:286:
+					_rte_eal_uev_callback_process(&dev->device, RTE_EAL_UEVENT_REMOVE, NULL, NULL);

total: 0 errors, 4 warnings, 664 lines checked