automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Santosh Shukla <santosh.shukla@caviumnetworks.com>
Subject: [dpdk-test-report] |WARNING| pw28358 [PATCH v2 1/5] eal: rename phys_addr_t to iova_addr_t
Date: Tue,  5 Sep 2017 12:32:13 +0200 (CEST)	[thread overview]
Message-ID: <20170905103213.94A647CD7@dpdk.org> (raw)
In-Reply-To: <20170905103119.20511-2-santosh.shukla@caviumnetworks.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/28358

_coding style issues_


CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'sc' may be better as '(sc)' to avoid precedence issues
#706: FILE: drivers/net/bnx2x/bnx2x.h:1245:
+#define GUNZIP_PHYS(sc)   (iova_addr_t)(sc->gz_buf_dma.paddr)

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#733: FILE: drivers/net/bnx2x/bnx2x.h:1405:
+    iova_addr_t fw_stat_map; /* (dma) valid if FUNC_FLG_STATS */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#734: FILE: drivers/net/bnx2x/bnx2x.h:1406:
+    iova_addr_t spq_map;     /* (dma) valid if FUNC_FLG_SPQ */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#771: FILE: drivers/net/bnx2x/bnx2x_stats.c:1341:
+    iova_addr_t cur_data_offset;$

WARNING:LONG_LINE: line over 90 characters
#1284: FILE: drivers/net/xenvirt/rte_xen_lib.c:358:
+grant_node_create(uint32_t pg_num, uint32_t *gref_arr, iova_addr_t *pa_arr, char *val_str, size_t str_size)

WARNING:LONG_LINE: line over 90 characters
#1293: FILE: drivers/net/xenvirt/rte_xen_lib.c:422:
+grant_gntalloc_mbuf_pool(struct rte_mempool *mpool, uint32_t pg_num, uint32_t *gref_arr, iova_addr_t *pa_arr, int mempool_idx)

WARNING:LONG_LINE: line over 90 characters
#1324: FILE: drivers/net/xenvirt/rte_xen_lib.h:111:
+int grant_node_create(uint32_t pg_num, uint32_t *gref_arr, iova_addr_t *pa_arr, char *val_str, size_t str_size);

WARNING:LONG_LINE: line over 90 characters
#1328: FILE: drivers/net/xenvirt/rte_xen_lib.h:114:
+grant_gntalloc_mbuf_pool(struct rte_mempool *mpool, uint32_t pg_num, uint32_t *gref_arr, iova_addr_t *pa_arr, int mempool_idx);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'int32_t' should also have an identifier name
#1472: FILE: lib/librte_eal/common/include/rte_memory.h:204:
+iova_addr_t rte_xen_mem_phy2mch(int32_t, const iova_addr_t);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'const iova_addr_t' should also have an identifier name
#1472: FILE: lib/librte_eal/common/include/rte_memory.h:204:
+iova_addr_t rte_xen_mem_phy2mch(int32_t, const iova_addr_t);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'iova_addr_t' should also have an identifier name
#1632: FILE: lib/librte_mbuf/rte_mbuf.h:414:
+	iova_addr_t buf_physaddr __rte_aligned(sizeof(iova_addr_t));

total: 0 errors, 10 warnings, 1350 lines checked

           reply	other threads:[~2017-09-05 10:32 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20170905103119.20511-2-santosh.shukla@caviumnetworks.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170905103213.94A647CD7@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=santosh.shukla@caviumnetworks.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).