automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Beilei Xing <beilei.xing@intel.com>
Subject: [dpdk-test-report] |WARNING| pw28437 [PATCH v2 3/6] net/i40e: finish integration FDIR with generic flow API
Date: Thu,  7 Sep 2017 13:21:42 +0200 (CEST)	[thread overview]
Message-ID: <20170907112142.A5415199C7@dpdk.org> (raw)
In-Reply-To: <1504783263-20575-4-git-send-email-beilei.xing@intel.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/28437

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <ETHER_TYPE_IPv4>
#236: FILE: drivers/net/i40e/i40e_fdir.c:989:
+		*ether_type = rte_cpu_to_be_16(ETHER_TYPE_IPv4);

CHECK:CAMELCASE: Avoid CamelCase: <ETHER_TYPE_IPv6>
#263: FILE: drivers/net/i40e/i40e_fdir.c:1016:
+		*ether_type = rte_cpu_to_be_16(ETHER_TYPE_IPv6);

CHECK:CAMELCASE: Avoid CamelCase: <I40E_FDIR_IPv6_DEFAULT_VTC_FLOW>
#265: FILE: drivers/net/i40e/i40e_fdir.c:1018:
+			rte_cpu_to_be_32(I40E_FDIR_IPv6_DEFAULT_VTC_FLOW |

CHECK:CAMELCASE: Avoid CamelCase: <I40E_FDIR_IPv6_TC_OFFSET>
#267: FILE: drivers/net/i40e/i40e_fdir.c:1020:
+					  I40E_FDIR_IPv6_TC_OFFSET));

CHECK:CAMELCASE: Avoid CamelCase: <I40E_FDIR_IPv6_PAYLOAD_LEN>
#269: FILE: drivers/net/i40e/i40e_fdir.c:1022:
+			rte_cpu_to_be_16(I40E_FDIR_IPv6_PAYLOAD_LEN);

CHECK:CAMELCASE: Avoid CamelCase: <I40E_FDIR_IPv6_DEFAULT_HOP_LIMITS>
#275: FILE: drivers/net/i40e/i40e_fdir.c:1028:
+					I40E_FDIR_IPv6_DEFAULT_HOP_LIMITS;

CHECK:BRACES: braces {} should be used on all arms of this statement
#510: FILE: drivers/net/i40e/i40e_fdir.c:1384:
+	if (hw->mac.type == I40E_MAC_X722) {
[...]
+	} else
[...]

CHECK:BRACES: Unbalanced braces around else statement
#516: FILE: drivers/net/i40e/i40e_fdir.c:1390:
+	} else

CHECK:BRACES: braces {} should be used on all arms of this statement
#661: FILE: drivers/net/i40e/i40e_fdir.c:1690:
+	if (fdir_action->behavior == I40E_FDIR_REJECT)
[...]
+	else if (fdir_action->behavior == I40E_FDIR_ACCEPT)
[...]
+	else if (fdir_action->behavior == I40E_FDIR_PASSTHRU)
[...]
+	else {
[...]

CHECK:BRACES: Unbalanced braces around else statement
#667: FILE: drivers/net/i40e/i40e_fdir.c:1696:
+	else {

total: 0 errors, 0 warnings, 10 checks, 897 lines checked

           reply	other threads:[~2017-09-07 11:21 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1504783263-20575-4-git-send-email-beilei.xing@intel.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170907112142.A5415199C7@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=beilei.xing@intel.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).