automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Shreyansh Jain <shreyansh.jain@nxp.com>
Subject: [dpdk-test-report] |WARNING| pw28546 [PATCH v4 25/41] net/dpaa: add support for Tx and Rx queue setup
Date: Sat,  9 Sep 2017 13:12:00 +0200 (CEST)	[thread overview]
Message-ID: <20170909111200.2800F1B1A6@dpdk.org> (raw)
In-Reply-To: <20170909112132.13936-26-shreyansh.jain@nxp.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/28546

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse '_mbuf' - possible side-effects?
#493: FILE: drivers/net/dpaa/dpaa_rxtx.c:77:
+#define DPAA_MBUF_TO_CONTIG_FD(_mbuf, _fd, _bpid) \
+	do { \
+		(_fd)->cmd = 0; \
+		(_fd)->opaque_addr = 0; \
+		(_fd)->opaque = QM_FD_CONTIG << DPAA_FD_FORMAT_SHIFT; \
+		(_fd)->opaque |= ((_mbuf)->data_off) << DPAA_FD_OFFSET_SHIFT; \
+		(_fd)->opaque |= (_mbuf)->pkt_len; \
+		(_fd)->addr = (_mbuf)->buf_physaddr; \
+		(_fd)->bpid = _bpid; \
+	} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse '_fd' - possible side-effects?
#493: FILE: drivers/net/dpaa/dpaa_rxtx.c:77:
+#define DPAA_MBUF_TO_CONTIG_FD(_mbuf, _fd, _bpid) \
+	do { \
+		(_fd)->cmd = 0; \
+		(_fd)->opaque_addr = 0; \
+		(_fd)->opaque = QM_FD_CONTIG << DPAA_FD_FORMAT_SHIFT; \
+		(_fd)->opaque |= ((_mbuf)->data_off) << DPAA_FD_OFFSET_SHIFT; \
+		(_fd)->opaque |= (_mbuf)->pkt_len; \
+		(_fd)->addr = (_mbuf)->buf_physaddr; \
+		(_fd)->bpid = _bpid; \
+	} while (0)

total: 0 errors, 0 warnings, 808 lines checked

           reply	other threads:[~2017-09-09 11:12 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20170909112132.13936-26-shreyansh.jain@nxp.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170909111200.2800F1B1A6@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=shreyansh.jain@nxp.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).