From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Nikhil Rao <nikhil.rao@intel.com>
Subject: [dpdk-test-report] |WARNING| pw28649 [PATCH 3/4] eventdev: Add eventdev ethernet Rx adapter
Date: Wed, 13 Sep 2017 12:16:16 +0200 (CEST) [thread overview]
Message-ID: <20170913101616.DA5621B160@dpdk.org> (raw)
In-Reply-To: <1505328781-23456-1-git-send-email-nikhil.rao@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/28649
_coding style issues_
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#249: FILE: lib/librte_eventdev/rte_event_eth_rx_adapter.h:203:
+ * struct rte_event_eth_rx_adapter_conf struct passed into
+ * it.
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#250: FILE: lib/librte_eventdev/rte_event_eth_rx_adapter.h:204:
+ * it.
+ *
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#575: FILE: lib/librte_eventdev/rte_event_eth_rx_adapter.c:137:
+#define RTE_EVENT_ETH_RX_ADAPTER_ID_VALID_OR_ERR_RET(id, retval) do { \
+ if (!valid_id(id)) { \
+ RTE_EDEV_LOG_ERR("Invalid eth Rx adapter id = %d
", id); \
+ return retval; \
+ } \
+} while (0)
WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'conf->rx_queue_flags'
#1198: FILE: lib/librte_eventdev/rte_event_eth_rx_adapter.c:760:
+ if (conf->
+ rx_queue_flags & RTE_EVENT_ETH_RX_ADAPTER_QUEUE_FLOW_ID_VALID) {
total: 0 errors, 4 warnings, 1663 lines checked
parent reply other threads:[~2017-09-13 10:16 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1505328781-23456-1-git-send-email-nikhil.rao@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170913101616.DA5621B160@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=nikhil.rao@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).