From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id DA5621B160; Wed, 13 Sep 2017 12:16:16 +0200 (CEST)
In-Reply-To: <1505328781-23456-1-git-send-email-nikhil.rao@intel.com>
References: <1505328781-23456-1-git-send-email-nikhil.rao@intel.com>
To: test-report@dpdk.org
Cc: Nikhil Rao <nikhil.rao@intel.com>
Message-Id: <20170913101616.DA5621B160@dpdk.org>
Date: Wed, 13 Sep 2017 12:16:16 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw28649 [PATCH 3/4] eventdev: Add
	eventdev ethernet Rx adapter
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Sep 2017 10:16:17 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/28649

_coding style issues_


WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#249: FILE: lib/librte_eventdev/rte_event_eth_rx_adapter.h:203:
+ *  struct rte_event_eth_rx_adapter_conf struct passed into
+	 *    it.

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#250: FILE: lib/librte_eventdev/rte_event_eth_rx_adapter.h:204:
+	 *    it.
+ *

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#575: FILE: lib/librte_eventdev/rte_event_eth_rx_adapter.c:137:
+#define RTE_EVENT_ETH_RX_ADAPTER_ID_VALID_OR_ERR_RET(id, retval) do { \
+	if (!valid_id(id)) { \
+		RTE_EDEV_LOG_ERR("Invalid eth Rx adapter id = %d
", id); \
+		return retval; \
+	} \
+} while (0)

WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'conf->rx_queue_flags'
#1198: FILE: lib/librte_eventdev/rte_event_eth_rx_adapter.c:760:
+	if (conf->
+	    rx_queue_flags & RTE_EVENT_ETH_RX_ADAPTER_QUEUE_FLOW_ID_VALID) {

total: 0 errors, 4 warnings, 1663 lines checked